Branch: refs/heads/master
  Home:   https://github.com/tianocore/edk2
  Commit: b17ac09cc4bb48692ec20ca583a8f70dc7d25d95
      
https://github.com/tianocore/edk2/commit/b17ac09cc4bb48692ec20ca583a8f70dc7d25d95
  Author: Ken Lautner <kenlautn...@gmail.com>
  Date:   2024-09-04 (Wed, 04 Sep 2024)

  Changed paths:
    M MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIo.c

  Log Message:
  -----------
  MdeModulePkg: Add extra RestoreTpl() call in DiskIo

Adds a call to RestoreTpl() in DiskIo2ReadWriteDisk(). While the current
implementation does not technically violate spec on raise/restore TPL,
this extra call ensures symmetry between RaiseTpl and RestoreTpl calls,
which makes analysis of TPL correctness simpler and permits certain
non-standard TPL usages that some platforms require.

Signed-off-by: Kenneth Lautner <kenlautn...@gmail.com>


  Commit: 559affab2e82aba4e0819d299d5a8de03e276af6
      
https://github.com/tianocore/edk2/commit/559affab2e82aba4e0819d299d5a8de03e276af6
  Author: Ken Lautner <kenlautn...@gmail.com>
  Date:   2024-09-04 (Wed, 04 Sep 2024)

  Changed paths:
    M MdeModulePkg/Core/Dxe/Image/Image.c
    M MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIo.c

  Log Message:
  -----------
  MdeModulePkg: Fix redundant call to RestoreTpl()

Comments out a redundant call to RestoreTpl(). While this does not
technically violate spec on raise/restore TPL, TPL should already be at
the specified level. This extra call introduces an asymmetry between
RaiseTpl and RestoreTpl calls, which makes analysis of TPL correctness
more difficult and hampers certain non-standard TPL usages that some
platforms require.  Additionally, the two TPL variables were renamed to
provide context for each of them.

Signed-off-by: Kenneth Lautner <kenlautn...@gmail.com>


Compare: https://github.com/tianocore/edk2/compare/afba5358c816...559affab2e82

To unsubscribe from these emails, change your notification settings at 
https://github.com/tianocore/edk2/settings/notifications


_______________________________________________
edk2-commits mailing list
edk2-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to