Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: c9a59facd85f75bd30a6b9c0cccd789bc34402b1
https://github.com/tianocore/edk2/commit/c9a59facd85f75bd30a6b9c0cccd789bc34402b1
Author: Mike Maslenkin <mike.maslen...@gmail.com>
Date: 2024-09-05 (Thu, 05 Sep 2024)
Changed paths:
M RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
Log Message:
-----------
RedfishPkg: RedfishDiscoverDxe: fix compilation warning
/RedfishDiscoverDxe.c:1979:37: error: 'RestExInstance' may be used
uninitialized in this function [-Werror=maybe-uninitialized]
RestExInstance->Signature = EFI_REDFISH_DISCOVER_DATA_SIGNATURE;
cc1: all warnings being treated as errors
Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com>
Commit: 7acd8c9bd25de8e6af84d1696a8f963eac582089
https://github.com/tianocore/edk2/commit/7acd8c9bd25de8e6af84d1696a8f963eac582089
Author: Mike Maslenkin <mike.maslen...@gmail.com>
Date: 2024-09-05 (Thu, 05 Sep 2024)
Changed paths:
M
RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.c
Log Message:
-----------
RedfishPkg: PlatformHostInterfaceBmcUsbNicLib: fix compilation warning
PlatformHostInterfaceBmcUsbNicLib.c: In function 'CheckBmcUsbNic':
PlatformHostInterfaceBmcUsbNicLib.c:1253:14: error: error: 'HandleBuffer'
may be used uninitialized in this function [-Werror=maybe-uninitialized]
Status =
CheckBmcUsbNicOnHandles (BufferSize/sizeof (EFI_HANDLE), HandleBuffer);
cc1: all warnings being treated as errors
Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com>
Commit: 7b9f2018d1f2a850eca2ce1431e9eba8f185a716
https://github.com/tianocore/edk2/commit/7b9f2018d1f2a850eca2ce1431e9eba8f185a716
Author: Mike Maslenkin <mike.maslen...@gmail.com>
Date: 2024-09-05 (Thu, 05 Sep 2024)
Changed paths:
M
RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.c
M
RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.h
M
RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.inf
Log Message:
-----------
RedfishPkg: PlatformHostInterfaceBmcUsbNicLib: use credential protocol
This patch replaces call of IpmiSubmitCommand() issued
REDFISH_IPMI_BOOTSTRAP_CREDENTIAL_ENABLE IPMI command to check
whether bootstrap credential support enabled or not.
The problem is that in accordance with IPMI spec while handling
such command BMC creates bootstrap account. The credentials of this account
is returned as a response. Obviously in this code the response is not used.
>From the other side there is an implementation
of EDKII_REDFISH_CREDENTIAL_PROTOCOL exists and used by
RedfishPlatformCredentialIpmiLib.
By design RedfishPlatformCredentialIpmiLib keeps returned bootstrap
credentials and uses it later. So all services using
EDKII_REDFISH_CREDENTIAL_PROTOCOL instance operates with a same
credentials.
Current design of PlatformHostInterfaceBmcUsbNicLib leads to creation
of two bootstrap accounts on BMC side. This is on nesseccary and one
account is not used at all.
Using EDKII_REDFISH_CREDENTIAL_PROTOCOL prevents from creating useless
bootstrap account on BMC side.
Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com>
Compare: https://github.com/tianocore/edk2/compare/2ddce71142a6...7b9f2018d1f2
To unsubscribe from these emails, change your notification settings at
https://github.com/tianocore/edk2/settings/notifications
_______________________________________________
edk2-commits mailing list
edk2-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-commits
