Branch: refs/heads/master Home: https://github.com/tianocore/edk2 Commit: af60615f0ef5f5d5ab3f9cea3215e07b8c73b600 https://github.com/tianocore/edk2/commit/af60615f0ef5f5d5ab3f9cea3215e07b8c73b600 Author: Mike Beaton <mjsbea...@gmail.com> Date: 2024-09-12 (Thu, 12 Sep 2024)
Changed paths: M NetworkPkg/NetworkPcds.dsc.inc Log Message: ----------- NetworkPkg: Fix unable to build OVMF with -D NETWORK_ENABLE=0 https://bugzilla.tianocore.org/show_bug.cgi?id=4829 7f17a15 (2024/02/22) "OvmfPkg: Shell*.inc: allow building without network support" breaks building OVMF with `-D NETWORK_ENABLE=0`. Before this commit we could build OVMF e.g. with the following command in the OvmfPkg directory: ./build.sh -D NETWORK_ENABLE=0 After the commit the same command fails early with: /home/user/OpenSource/edk2/OvmfPkg/OvmfPkgX64.dsc(15): error F001: Pcd (gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections) defined in DSC is not declared in DEC files referenced in INF files in FDF. Arch: ['X64'] This commit conditionally removes the undefined Pcd reference in NetworkPkg which is part of this issue. Similar changes are needed in separate commits for OvmfPkg (and for ArmVirtPkg, since the issue also exists there, although masked by another issue). Signed-off-by: Mike Beaton <mjsbea...@gmail.com> Commit: 14d7ae94bc1d3367703a674b862748cb117b71c8 https://github.com/tianocore/edk2/commit/14d7ae94bc1d3367703a674b862748cb117b71c8 Author: Mike Beaton <mjsbea...@gmail.com> Date: 2024-09-12 (Thu, 12 Sep 2024) Changed paths: M OvmfPkg/CloudHv/CloudHvX64.dsc M OvmfPkg/LoongArchVirt/LoongArchVirtQemu.dsc M OvmfPkg/Microvm/MicrovmX64.dsc M OvmfPkg/OvmfPkgIa32.dsc M OvmfPkg/OvmfPkgIa32X64.dsc M OvmfPkg/OvmfPkgX64.dsc M OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc Log Message: ----------- OvmfPkg: Fix unable to build OVMF with -D NETWORK_ENABLE=0 https://bugzilla.tianocore.org/show_bug.cgi?id=4829 7f17a15 (2024/02/22) "OvmfPkg: Shell*.inc: allow building without network support" breaks building OVMF with `-D NETWORK_ENABLE=0`. Before this commit we could build OVMF e.g. with the following command in the OvmfPkg directory: ./build.sh -D NETWORK_ENABLE=0 After the commit the same command fails early with: /home/user/OpenSource/edk2/OvmfPkg/OvmfPkgX64.dsc(15): error F001: Pcd (gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections) defined in DSC is not declared in DEC files referenced in INF files in FDF. Arch: ['X64'] The problem applies in Intel OvmfPkg platforms. Additionally, it applies in various other OvmfPkg platforms, but is masked buy another issue; namely that these platforms incorrectly still include some network packages when most are disabled. (A fix for that issue has previously been made, in OvmfPkg Intel platforms only, by d933ec1 followed by 7f17a15 .) This commit conditionally removes the undefined Pcd references in all OvmfPkg platforms which are now affected by this issue, and in all those which would be affected as and when the other issue mentioned above is fixed. Signed-off-by: Mike Beaton <mjsbea...@gmail.com> Commit: bb403511d412959aaa3733a8235257190d63b3ad https://github.com/tianocore/edk2/commit/bb403511d412959aaa3733a8235257190d63b3ad Author: Mike Beaton <mjsbea...@gmail.com> Date: 2024-09-12 (Thu, 12 Sep 2024) Changed paths: M ArmVirtPkg/ArmVirtQemu.dsc M ArmVirtPkg/ArmVirtQemuKernel.dsc Log Message: ----------- ArmVirtPkg: Fix unable to build with -D NETWORK_ENABLE=0 https://bugzilla.tianocore.org/show_bug.cgi?id=4829 7f17a15 (2024/02/22) "OvmfPkg: Shell*.inc: allow building without network support" breaks building OVMF with `-D NETWORK_ENABLE=0`. Before this commit we could build OVMF e.g. with the following command in the OvmfPkg directory: ./build.sh -D NETWORK_ENABLE=0 After the commit the same command fails early with: /home/user/OpenSource/edk2/OvmfPkg/OvmfPkgX64.dsc(15): error F001: Pcd (gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections) defined in DSC is not declared in DEC files referenced in INF files in FDF. Arch: ['X64'] This problem also applies in the ArmVirtPkg platforms which are modified here, but is currently masked by another issue, namely that these platforms incorrectly still include some network packages when most are disabled. (A fix for this was previously applied, for OvmfPkg Intel platforms only, by d933ec1 followed by 7f17a15 .) This commit was created at the same time as the commits resolving this issue in NetworkPkg and OvmfPkg. It makes conditional the Pcd references in ArmVirtPkg platforms which will become references to undefined Pcds as and when the other issue mentioned above is fixed. Signed-off-by: Mike Beaton <mjsbea...@gmail.com> Compare: https://github.com/tianocore/edk2/compare/8f74b95a21cf...bb403511d412 To unsubscribe from these emails, change your notification settings at https://github.com/tianocore/edk2/settings/notifications _______________________________________________ edk2-commits mailing list edk2-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-commits