Branch: refs/heads/master
  Home:   https://github.com/tianocore/edk2
  Commit: f6aba88ac8af6d4561a2f0f452e13564dde9d029
      
https://github.com/tianocore/edk2/commit/f6aba88ac8af6d4561a2f0f452e13564dde9d029
  Author: Leif Lindholm <leif.lindh...@oss.qualcomm.com>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLibStandaloneMm.c

  Log Message:
  -----------
  MdeModulePkg/VarCheckHiiLib: don't return success for invalid input

The doxygen comment for VarCheckHiiLibReceiveHiiBinHandler says that
EFI_INVALID_PARAMETER should be returned if either of CommBuffer or
CommBufferSize is NULL, but the test results in an early return of
EFI_SUCCESS.

Update the code to match the documentation.

Signed-off-by: Leif Lindholm <leif.lindh...@oss.qualcomm.com>


  Commit: 22919e560bda6d71ce18ac6c86ef4e7716c0082d
      
https://github.com/tianocore/edk2/commit/22919e560bda6d71ce18ac6c86ef4e7716c0082d
  Author: Leif Lindholm <leif.lindh...@oss.qualcomm.com>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLibStandaloneMm.c

  Log Message:
  -----------
  MdeModulePkg/VarCheckHiiLib: clean up VarCheckHiiLibReceiveHiiBinHandler

Building VarCheckHiiLib fails on my clang 19.1.6 setup with the error
 variable 'Status' is used uninitialized whenever 'if' condition is false
due to the DispatchHandle != NULL test.

Calling this function with a NULL handle makes no sense, so move the test
to the function entry and return failure if appropriate.

Signed-off-by: Leif Lindholm <leif.lindh...@oss.qualcomm.com>


Compare: https://github.com/tianocore/edk2/compare/1c6ce560f042...22919e560bda

To unsubscribe from these emails, change your notification settings at 
https://github.com/tianocore/edk2/settings/notifications


_______________________________________________
edk2-commits mailing list
edk2-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to