Branch: refs/heads/master
  Home:   https://github.com/tianocore/edk2
  Commit: 27d44c1abd676a8db2cb92f231e2bc4cc89370da
      
https://github.com/tianocore/edk2/commit/27d44c1abd676a8db2cb92f231e2bc4cc89370da
  Author: Leif Lindholm <leif.lindh...@oss.qualcomm.com>
  Date:   2025-07-02 (Wed, 02 Jul 2025)

  Changed paths:
    M BaseTools/Scripts/PatchCheck.py

  Log Message:
  -----------
  BaseTools/PatchCheck.py: drop redundant line count check

Before doing the subject line length check, the script checks that the
number of lines in the commit message (including subject) is not less
than or equal to zero - and returns if it is.

However, then the test for whether the subject line starts with a CVE
tag inexplicably also checks for whether the number of lines are
greater than or equal to one. This is just clutter, so drop it.

Signed-off-by: Leif Lindholm <leif.lindh...@oss.qualcomm.com>


  Commit: 2bcad870049ae495eb8884b6ece893548fee770c
      
https://github.com/tianocore/edk2/commit/2bcad870049ae495eb8884b6ece893548fee770c
  Author: Leif Lindholm <leif.lindh...@oss.qualcomm.com>
  Date:   2025-07-02 (Wed, 02 Jul 2025)

  Changed paths:
    M BaseTools/Scripts/PatchCheck.py

  Log Message:
  -----------
  BaseTools/PatchCheck.py: clean up subject line length handling

Use a temporary variable for max subject line length and log
result of test in one location.

Signed-off-by: Leif Lindholm <leif.lindh...@oss.qualcomm.com>


  Commit: 87a4bfd28c1f45f29a0c8826dfe981e1ebc12fa8
      
https://github.com/tianocore/edk2/commit/87a4bfd28c1f45f29a0c8826dfe981e1ebc12fa8
  Author: Leif Lindholm <leif.lindh...@oss.qualcomm.com>
  Date:   2025-07-02 (Wed, 02 Jul 2025)

  Changed paths:
    M BaseTools/Scripts/PatchCheck.py

  Log Message:
  -----------
  BaseTools/PatchCheck.py: permit at least 20 characters after ':'

Commit b55530ad4460
("BaseTools/PatchCheck.py: verify commit message lists package(s)")
introduced a check for the requirement to enumerate all modified packages
in the commit subject line. But it did leave the maximum line length at
75 characters (for non-CVE commits), which can get a bit cramped for
changes to several packages.

Introduce a new arbitrary "at least 20 characters after the :" limit.

Signed-off-by: Leif Lindholm <leif.lindh...@oss.qualcomm.com>


Compare: https://github.com/tianocore/edk2/compare/7c40bc06a9d3...87a4bfd28c1f

To unsubscribe from these emails, change your notification settings at 
https://github.com/tianocore/edk2/settings/notifications


_______________________________________________
edk2-commits mailing list
edk2-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-commits

Reply via email to