Branch: refs/heads/master Home: https://github.com/tianocore/edk2 Commit: c37e2d38d6019b44ee8e56209027c717eb3f1f32 https://github.com/tianocore/edk2/commit/c37e2d38d6019b44ee8e56209027c717eb3f1f32 Author: Laszlo Ersek <laszlo.er...@posteo.net> Date: 2025-07-23 (Wed, 23 Jul 2025)
Changed paths: M OvmfPkg/Include/Library/PlatformInitLib.h M OvmfPkg/PlatformPei/FeatureControl.c Log Message: ----------- OvmfPkg/PlatformPei: record "etc/msr_feature_control" presence explicitly A zero "FeatureControlValue" currently means "no feature control, or feature control with zero value". Distinguish both cases by explicitly recording the presence of the "etc/msr_feature_control" fw_cfg file. This will be helpful later in this series, when we won't want to touch fw_cfg again, but still know if "etc/msr_feature_control" was read OK. Signed-off-by: Laszlo Ersek <laszlo.er...@posteo.net> Commit: f92ba13a665701537193798f7bcaf65398ac6180 https://github.com/tianocore/edk2/commit/f92ba13a665701537193798f7bcaf65398ac6180 Author: Laszlo Ersek <laszlo.er...@posteo.net> Date: 2025-07-23 (Wed, 23 Jul 2025) Changed paths: M OvmfPkg/CpuHotplugSmm/FirstSmiHandler.nasm Log Message: ----------- OvmfPkg/CpuHotplugSmm: add whitespace In a subsequent patch, we'll introduce fields with long names to "FIRST_SMI_HANDLER_CONTEXT". Make room for those field names in "FirstSmiHandler.nasm". "git show -b" produces no patch output for this commit. Signed-off-by: Laszlo Ersek <laszlo.er...@posteo.net> Commit: 0e814e829e5fb901a89937340a470ab3cda83de7 https://github.com/tianocore/edk2/commit/0e814e829e5fb901a89937340a470ab3cda83de7 Author: Laszlo Ersek <laszlo.er...@posteo.net> Date: 2025-07-23 (Wed, 23 Jul 2025) Changed paths: M OvmfPkg/CpuHotplugSmm/FirstSmiHandler.nasm M OvmfPkg/CpuHotplugSmm/FirstSmiHandlerContext.h M OvmfPkg/CpuHotplugSmm/Smbase.c Log Message: ----------- OvmfPkg/CpuHotplugSmm: set MSR_IA32_FEATURE_CONTROL in first SMI handler Introduce new fields to FIRST_SMI_HANDLER_CONTEXT: - a UINT8 (effectively: boolean) value that controls whether the first SMI handler of the hot-added CPU is supposed to set MSR_IA32_FEATURE_CONTROL, - and for when that is the case, two UINT32 values, for passing the desired EDX:EAX (64-bit) MSR value. MSR_IA32_FEATURE_CONTROL might as well be settable in the post-SMM pen ("PostSmmPen.nasm"); however, I find the first SMI handler better for this purpose: - we already have a nice context structure we can extend, - in SMM, we have tighter control than after SMM (see the comments near the top of "PostSmmPen.nasm"). MSR_IA32_FEATURE_CONTROL is orthogonal to the SMRAM State Save Map, and WRMSR is permitted in the real mode-like initial environment of SMM, so functionally speaking, this should be fine. For now, the feature is disabled. Signed-off-by: Laszlo Ersek <laszlo.er...@posteo.net> Commit: 43d696a3667a808dbe9117cf8131dbfa64dcf631 https://github.com/tianocore/edk2/commit/43d696a3667a808dbe9117cf8131dbfa64dcf631 Author: Laszlo Ersek <laszlo.er...@posteo.net> Date: 2025-07-23 (Wed, 23 Jul 2025) Changed paths: M OvmfPkg/CpuHotplugSmm/CpuHotplugSmm.inf M OvmfPkg/CpuHotplugSmm/Smbase.c Log Message: ----------- OvmfPkg/CpuHotplugSmm: hook up MSR_IA32_FEATURE_CONTROL with platform info Map the feature control MSR config from the OVMF platform info HOB to FIRST_SMI_HANDLER_CONTEXT. (Note that CpuHotplugSmm already consumes -- indirectly -- the "MdePkg/Library/DxeHobLib/DxeHobLib.inf" library instance, according to the build report; therefore adding an explicit HobLib class dependency shouldn't *generally* increase this SMM driver's exposure. The consumed lib instances are the same before and after this patch, at least in "OvmfPkgIa32X64.dsc".) Fixes: https://github.com/tianocore/edk2/issues/11188 Signed-off-by: Laszlo Ersek <laszlo.er...@posteo.net> Compare: https://github.com/tianocore/edk2/compare/c27552f3431d...43d696a3667a To unsubscribe from these emails, change your notification settings at https://github.com/tianocore/edk2/settings/notifications _______________________________________________ edk2-commits mailing list edk2-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-commits