Jordan Justen [mailto:jordan.l.jus...@intel.com] wrote:
]Sent: Saturday, July 18, 2015 12:52 AM
]To: Scott Duplichan <sc...@notabs.org>; edk2-de...@ml01.01.org
]Cc: 'Ni, Ruiyu' <ruiyu...@intel.com>; 'Maurice Ma' <maurice...@intel.com>;
'Yingke D Liu' ]<yingke.d....@intel.com>; 'Prince Agyeman'
<prince.agye...@intel.com>; 'Laszlo Ersek' <ler...@redhat.com>
]Subject: Re: [PATCH]: CorebootPayloadPkg: Remove data alignment restriction to
support GCC49
]
]On 2015-07-17 21:23:16, Scott Duplichan wrote:
]> Gcc 4.9 produces data alignments of up to 64 bytes. Previous gcc
]> versions align data at up to 32 bytes. With GCC49, this difference
]> causes CorebootPayloadPkg to hang after PeCoffLoaderLoadImage() sets
]> ImageError to IMAGE_ERROR_INVALID_SECTION_ALIGNMENT and returns an
]> error. This change removes the restriction. Testing with
]> __attribute__((aligned ())) passes for data alignments of up to 256
]> bytes.
]
]I think I prefer Ray's commit message in r17902.
Thanks Jordan. Here is Ray's commit message:
Fix GCC49 build hang in PeiCore
This message says "Fix GCC49 build hang". There is no build
hang. The build completes successfully. The problem is a boot
hang. That is why I didn't use this commit message.
The problem is the length limitation on the commit message.
It is sometimes impossible to make a good commit message that
meets the length limit.
Thanks,
Scott
]Nevertheless, Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com>
]
]> Contributed-under: TianoCore Contribution Agreement 1.0
]> Signed-off-by: Scott Duplichan <sc...@notabs.org>
]
]Consider Cc'ing Maurice and Prince (and others) here in the commit
]message. (Just a tip to make your life easier in the future.)
]
]-Jordan
]
> ---
>
> CorebootPayloadPkg/CorebootPayloadPkg.fdf | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/CorebootPayloadPkg/CorebootPayloadPkg.fdf
> b/CorebootPayloadPkg/CorebootPayloadPkg.fdf
> index 810dcb1..198c150 100644
> --- a/CorebootPayloadPkg/CorebootPayloadPkg.fdf
> +++ b/CorebootPayloadPkg/CorebootPayloadPkg.fdf
> @@ -189,12 +189,12 @@ INF CorebootPayloadPkg/FbGop/FbGop.inf
>
> [Rule.Common.SEC]
> FILE SEC = $(NAMED_GUID) {
> - PE32 PE32 Align=32 $(INF_OUTPUT)/$(MODULE_NAME).efi
> + PE32 PE32 Align=Auto $(INF_OUTPUT)/$(MODULE_NAME).efi
> }
>
> [Rule.Common.PEI_CORE]
> FILE PEI_CORE = $(NAMED_GUID) {
> - PE32 PE32 Align=32 $(INF_OUTPUT)/$(MODULE_NAME).efi
> + PE32 PE32 Align=Auto $(INF_OUTPUT)/$(MODULE_NAME).efi
> UI STRING ="$(MODULE_NAME)" Optional
> VERSION STRING ="$(INF_VERSION)" Optional BUILD_NUM=$(BUILD_NUMBER)
> }
> @@ -202,7 +202,7 @@ INF CorebootPayloadPkg/FbGop/FbGop.inf
> [Rule.Common.PEIM]
> FILE PEIM = $(NAMED_GUID) {
> PEI_DEPEX PEI_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex
> - PE32 PE32 Align=32 $(INF_OUTPUT)/$(MODULE_NAME).efi
> + PE32 PE32 Align=Auto $(INF_OUTPUT)/$(MODULE_NAME).efi
> UI STRING="$(MODULE_NAME)" Optional
> VERSION STRING="$(INF_VERSION)" Optional BUILD_NUM=$(BUILD_NUMBER)
> }
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
