On 26 July 2015 at 12:52, Leif Lindholm <[email protected]> wrote: > On Sun, Jul 26, 2015 at 11:50:53AM +0200, Ard Biesheuvel wrote: >> On 26 July 2015 at 11:50, Laszlo Ersek <[email protected]> wrote: >> > On 07/26/15 11:40, Ard Biesheuvel wrote: >> >> The current GIC revision detection code infers the GIC revision from >> >> the AA64PFR0_EL1.GIC feature bit that tells us whether the GIC system >> >> register interface is implemented in the hardware, and then proceeds >> >> to attempt and enable it. >> >> >> >> The library containing this code deliberately does not cache the >> >> detected revision since it may execute in place before PEI memory >> >> has been set up. >> >> >> >> However, since the detection code runs very often, and is quite >> >> heavy-weight when running under virtualization (especially KVM), >> >> this series refactors the GIC revision detection to: >> >> - use fewer system register accesses if possible (*) >> >> - provide an alternative that does cache the detected revision >> >> - use the DT supplied revision when executing on a DT based platform >> >> >> >> Changes since v1: >> >> - the original patch #1 which implements (*) above was already merged as >> >> SVN r17596, so it has been dropped from this series >> >> - added R-b's and acks from Laszlo >> > >> > So, as far as I understand, you need reviews from Leif, for the ArmPkg >> > patches, and then this can be committed. Correct? >> >> Indeed. > > So ... had a look through, looks sane, have a couple of minor comments > (will add inline). > But what I don't have at home is a useful hardware platform to test > this on. Has anyone else tested on 32-bit/64-bit hardware? >
Only under KVM, which is not very useful to you. I was kind of hoping you could push it through the CI Olivier always talked about. Or was that his personal setup? Do note that, even if they are non-trivial patches, the only actual change to non-virt platforms is that, for non-SEC modules, the result of the GIC detection is cached in a global. -- Ard. _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
