Yes, these 2 typedefs is being defined twice, we need to remove the second definition, I will check in the code patch. thank you Bruce.
Best Regards, Tim -----Original Message----- From: Bruce Cran [mailto:[email protected]] Sent: Monday, July 27, 2015 11:22 PM To: He, Tim Cc: Wei, David; [email protected] Subject: Re: [PATCH] Vlv2DeviceRefCodePkg: don't redefine struct typedefs On Mon, Jul 27, 2015 at 08:08:55AM +0000, He, Tim wrote: > I downloaded the patch from the Github URL that you sent, and reviewed the > patch, we can't remove these 2 typedefs, it would build failed because we are > using the typedefs. As far as I know, I'm just removing the *second* definition of the typedefs; they should still be defined. The code is: // Forward reference for ANSI C compatibility // typedef struct _PPM_PLATFORM_POLICY_PROTOCOL PPM_PLATFORM_POLICY_PROTOCOL; then, 100 or so lines later: typedef struct _PPM_PLATFORM_POLICY_PROTOCOL { ... ... } PPM_PLATFORM_POLICY_PROTOCOL; So, currently PPM_PLATFORM_POLICY_PROTOCOL is being defined twice. My patch removes the second definition. -- Bruce _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
