Reviewed-by: Eric Dong <eric.d...@intel.com>
-----Original Message-----
From: Bi, Dandan
Sent: Tuesday, August 04, 2015 12:51 PM
To: Dong, Eric; Qiu, Shumin; edk2-devel@lists.01.org
Subject: [patch 2/2] MdeModulePkg:Refine the code comments in UiApp
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan...@intel.com>
---
.../Application/UiApp/BootMaint/BootMaint.c | 1 -
.../Application/UiApp/DeviceMngr/DeviceManager.h | 4 +-
MdeModulePkg/Application/UiApp/FrontPage.c | 4 ++
MdeModulePkg/Application/UiApp/String.c | 4 ++
MdeModulePkg/Application/UiApp/String.h | 4 ++
MdeModulePkg/Application/UiApp/UiApp.inf | 55 ++++++++++++----------
.../Include/Guid/HiiBootMaintenanceFormset.h | 1 -
7 files changed, 45 insertions(+), 28 deletions(-)
diff --git a/MdeModulePkg/Application/UiApp/BootMaint/BootMaint.c
b/MdeModulePkg/Application/UiApp/BootMaint/BootMaint.c
index 4f46ed6..91af489 100644
--- a/MdeModulePkg/Application/UiApp/BootMaint/BootMaint.c
+++ b/MdeModulePkg/Application/UiApp/BootMaint/BootMaint.c
@@ -1358,11 +1358,10 @@ InitBootMaintenance(
/**
Remove the installed BootMaint and FileExplorer HiiPackages.
**/
-
VOID
FreeBMPackage(
VOID
)
{
diff --git a/MdeModulePkg/Application/UiApp/DeviceMngr/DeviceManager.h
b/MdeModulePkg/Application/UiApp/DeviceMngr/DeviceManager.h
index 7fb68a3..057fc47 100644
--- a/MdeModulePkg/Application/UiApp/DeviceMngr/DeviceManager.h
+++ b/MdeModulePkg/Application/UiApp/DeviceMngr/DeviceManager.h
@@ -137,19 +137,19 @@ InitializeDeviceManager (
**/
VOID
FreeDeviceManager(
VOID
-);
+ );
/**
Dynamic create Hii information for Device Manager.
@param NextShowFormId The FormId which need to be show.
**/
VOID
CreateDeviceManagerForm(
IN EFI_FORM_ID NextShowFormId
-);
+ );
#endif
diff --git a/MdeModulePkg/Application/UiApp/FrontPage.c
b/MdeModulePkg/Application/UiApp/FrontPage.c
index 7d1cf2a..d30935b 100644
--- a/MdeModulePkg/Application/UiApp/FrontPage.c
+++ b/MdeModulePkg/Application/UiApp/FrontPage.c
@@ -596,10 +596,14 @@ CallFrontPage (
}
return Status;
}
+/**
+ Remove the installed packages from the HiiDatabase.
+
+**/
VOID
FreeFrontPage(
VOID
)
{
diff --git a/MdeModulePkg/Application/UiApp/String.c
b/MdeModulePkg/Application/UiApp/String.c
index ad3ba57..b93b8ac 100644
--- a/MdeModulePkg/Application/UiApp/String.c
+++ b/MdeModulePkg/Application/UiApp/String.c
@@ -38,10 +38,14 @@ InitializeStringSupport (
NULL
);
ASSERT (gStringPackHandle != NULL);
}
+/**
+ Remove the string package.
+
+**/
VOID
UninitializeStringSupport (
VOID
)
{
diff --git a/MdeModulePkg/Application/UiApp/String.h
b/MdeModulePkg/Application/UiApp/String.h
index 1a06366..1aac6e8 100644
--- a/MdeModulePkg/Application/UiApp/String.h
+++ b/MdeModulePkg/Application/UiApp/String.h
@@ -54,10 +54,14 @@ GetStringById (
VOID
InitializeStringSupport (
VOID
);
+/**
+ Remove the string package.
+
+**/
VOID
UninitializeStringSupport (
VOID
);
diff --git a/MdeModulePkg/Application/UiApp/UiApp.inf
b/MdeModulePkg/Application/UiApp/UiApp.inf
index 626f558..26c6b1b 100644
--- a/MdeModulePkg/Application/UiApp/UiApp.inf
+++ b/MdeModulePkg/Application/UiApp/UiApp.inf
@@ -57,10 +57,11 @@
FrontPage.c
String.c
String.h
Language.c
Language.h
+ FormsetGuid.h
[Packages]
MdePkg/MdePkg.dec
MdeModulePkg/MdeModulePkg.dec
@@ -104,36 +105,42 @@
gEfiIfrTianoGuid ## CONSUMES ## GUID (Extended
IFR Guid Opcode)
gEfiHiiDriverHealthFormsetGuid ## CONSUMES ## GUID (Indicate
the Driver Health formset class guid to be displayed)
gEfiIfrBootMaintenanceGuid ## CONSUMES ## GUID
[Protocols]
- gEfiSimpleFileSystemProtocolGuid ## PROTOCOL CONSUMES
- gEfiLoadFileProtocolGuid ## PROTOCOL CONSUMES
- gEfiSmbiosProtocolGuid ## PROTOCOL CONSUMES
- gEfiGenericMemTestProtocolGuid ## PROTOCOL CONSUMES
- gEfiUgaDrawProtocolGuid |PcdUgaConsumeSupport ## PROTOCOL SOMETIMES_CONSUMES
- gEfiBlockIoProtocolGuid ## PROTOCOL CONSUMES
- gEfiGraphicsOutputProtocolGuid ## PROTOCOL SOMETIMES_CONSUMES
- gEfiSimpleTextInputExProtocolGuid ## PROTOCOL CONSUMES
- gEfiHiiConfigAccessProtocolGuid ## PROTOCOL CONSUMES
- gEfiFormBrowser2ProtocolGuid ## PROTOCOL CONSUMES
- gEfiSerialIoProtocolGuid ## PROTOCOL CONSUMES
- gEfiDevicePathProtocolGuid ## PROTOCOL CONSUMES
- gEfiPciIoProtocolGuid ## PROTOCOL CONSUMES
- gEfiDevicePathToTextProtocolGuid ## PROTOCOL CONSUMES
- gEfiBootLogoProtocolGuid ## PROTOCOL CONSUMES
+ gEfiSimpleFileSystemProtocolGuid ## CONSUMES
+ gEfiLoadFileProtocolGuid ## CONSUMES
+ gEfiSmbiosProtocolGuid ## CONSUMES
+ gEfiGenericMemTestProtocolGuid ## CONSUMES
+ gEfiUgaDrawProtocolGuid |PcdUgaConsumeSupport ## SOMETIMES_CONSUMES
+ gEfiBlockIoProtocolGuid ## CONSUMES
+ gEfiGraphicsOutputProtocolGuid ## SOMETIMES_CONSUMES
+ gEfiSimpleTextInputExProtocolGuid ## CONSUMES
+ gEfiHiiConfigAccessProtocolGuid ## CONSUMES
+ gEfiFormBrowser2ProtocolGuid ## CONSUMES
+ gEfiSerialIoProtocolGuid ## CONSUMES
+ gEfiDevicePathProtocolGuid ## CONSUMES
+ gEfiPciIoProtocolGuid ## CONSUMES
+ gEfiDevicePathToTextProtocolGuid ## CONSUMES
+ gEfiBootLogoProtocolGuid ## CONSUMES
[FeaturePcd]
[Pcd]
- gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultPlatformLangCodes
- gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultPlatformLang
- gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow
- gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn
+ gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultPlatformLangCodes ## CONSUMES
+ gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultPlatformLang ##
SOMETIMES_CONSUMES
+ gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow ## PRODUCES
+ gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn ## PRODUCES
+ ## CONSUMES
+ ## PRODUCES
gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut
- gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution
- gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution
+ gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution ## PRODUCES
+ gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution ## PRODUCES
+ ## CONSUMES
+ ## SOMETIMES_PRODUCES
gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutColumn
+ ## CONSUMES
+ ## SOMETIMES_PRODUCES
gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow
- gEfiMdeModulePkgTokenSpaceGuid.PcdSetupVideoHorizontalResolution
- gEfiMdeModulePkgTokenSpaceGuid.PcdSetupVideoVerticalResolution
- gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString
+ gEfiMdeModulePkgTokenSpaceGuid.PcdSetupVideoHorizontalResolution ## CONSUMES
+ gEfiMdeModulePkgTokenSpaceGuid.PcdSetupVideoVerticalResolution ## CONSUMES
+ gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString ## CONSUMES
\ No newline at end of file
diff --git a/MdeModulePkg/Include/Guid/HiiBootMaintenanceFormset.h
b/MdeModulePkg/Include/Guid/HiiBootMaintenanceFormset.h
index 96c39f9..25dcff8 100644
--- a/MdeModulePkg/Include/Guid/HiiBootMaintenanceFormset.h
+++ b/MdeModulePkg/Include/Guid/HiiBootMaintenanceFormset.h
@@ -1,6 +1,5 @@
-//
/** @file
Guid definition for Boot Maintainence Formset.
Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> This program
and the accompanying materials
--
1.9.5.msysgit.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
