On 4 August 2015 at 16:50, Laszlo Ersek <ler...@redhat.com> wrote:
> On 08/04/15 16:34, Ard Biesheuvel wrote:
>> On 4 August 2015 at 15:35, Laszlo Ersek <ler...@redhat.com> wrote:
[...]
>>> I propose the following:
>>> - The Xen hit should be removed as a separate patch, as it has never
>>>   been useful. (The Xen build uses Intel BDS exclusively.)
>>
>> OK
>>
>>> - The rest of the PCDs (in ArmVirtQemu.dsc and in ArmVirt.dsc.inc)
>>>   should be removed as part of this patch. In practice, those are:
>>>   - PcdFirmwareVendor (both files)
>>>   - PcdDefaultConOutPaths (two instances)
>>>   - PcdDefaultConInPaths (two instance)
>>>
>>> After you remove these, only
>>> gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType remains in this context,
>>> so please refresh both the leading comment, and the
>>> TTY_TERMINAL-dependent comments just below it. (They make references to
>>> ConOut/ConIn, and Intel BDS being optional.)
>>>
>>
>> I will remove the comment, since it suggests that ConIn/ConOut is
>> unused under the Intel BDS, but that is clearly not the case.
>
> You refer to
> - gArmPlatformTokenSpaceGuid.PcdDefaultConInPaths
> - gArmPlatformTokenSpaceGuid.PcdDefaultConOutPaths
> as being used by
>
>   ArmPlatformPkg/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
>
> That is correct. However, ArmVirtQemu.dsc does not resolve
> PlatformBdsLib to that instance; it uses
>
>   ArmVirtPkg/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf
>
> instead.
>
> Since your patch modifies ArmVirtQemu (where the ArmPlatformPkg library
> instance is unused), the PCDs should be removed.
>
> (The report files can be trusted about PCD usage.)
>
> The ArmPlatformPkg library instance is indeed used by ArmVirtXen, but
> the patch doesn't touch that file.
>

OK, good. I got confused by the fact that nothing under
ArmPlatformPkg/ actually uses this instance, but indeed, ArmVirtQemu
has its own.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to