Reviewed-by: Jiaxin Wu <jiaxin...@intel.com>
-----Original Message-----
From: Wang, Fan
Sent: Friday, August 7, 2015 9:33 AM
To: edk2-devel@lists.01.org
Cc: Ye, Ting; Wu, Jiaxin; Fu, Siyuan
Subject: [Patch] MdeModulePkg: Change the macro name to fit coding style
Change a macro name to fit EDK2 naming conventions: Use all capital letters for
#define.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: fanwang2 <fan.w...@intel.com>
---
MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c | 2 +-
MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c
b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c
index 621fbc0..ebd9f5b 100644
--- a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c
+++ b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c
@@ -818,11 +818,11 @@ IScsiGetTcpConnDevicePath (
// Add a judgement here to support previous versions of
IPv4_DEVICE_PATH.
// In previous versions of IPv4_DEVICE_PATH, GatewayIpAddress and
SubnetMask
// do not exist.
// In new version of IPv4_DEVICE_PATH, structcure length is 27.
//
- if (DevicePathNodeLength (&DPathNode->Ipv4) ==
IPv4_NODE_LEN_NEW_VERSIONS) {
+ if (DevicePathNodeLength (&DPathNode->Ipv4) ==
+ IP4_NODE_LEN_NEW_VERSIONS) {
IP4_COPY_ADDRESS (
&DPathNode->Ipv4.GatewayIpAddress,
&Session->ConfigData.NvData.Gateway
);
diff --git a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.h
b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.h
index 0bb7da0..8a95493 100644
--- a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.h
+++ b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.h
@@ -20,11 +20,11 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
EXPRESS OR IMPLIED.
typedef struct _ISCSI_SESSION_CONFIG_DATA ISCSI_SESSION_CONFIG_DATA;
///
/// IPv4 Device Path Node Length
///
-#define IPv4_NODE_LEN_NEW_VERSIONS 27
+#define IP4_NODE_LEN_NEW_VERSIONS 27
#pragma pack(1)
typedef struct {
BOOLEAN Enabled;
--
1.9.5.msysgit.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
