On 11 August 2015 at 14:26, Laszlo Ersek <ler...@redhat.com> wrote: > On 08/10/15 16:00, Ard Biesheuvel wrote: >> CLANG chokes on the value 0XEA1 since it expects the 0x prefix >> to use a lower case x. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> >> --- >> OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h >> b/OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h >> index 655a221f6337..625a0fc99416 100644 >> --- a/OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h >> +++ b/OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h >> @@ -168,7 +168,7 @@ >> * at Documentation/devicetree/bindings/arm/xen.txt. >> */ >> >> -#define XEN_HYPERCALL_TAG 0XEA1 >> +#define XEN_HYPERCALL_TAG 0xEA1 >> >> #define uint64_aligned_t UINT64 __attribute__((aligned(8))) >> >> > > That's a CLANG bug actually (refer to 6.4.4.1 Integer constants: > > hexadecimal-prefix: one of > 0x 0X > ) > > but I find 0X terribly unreadable myself, so yeah. >
Well, I suppose you are quoting the C standard there, but what I failed to mention is that it is actually the clang aarch64 assembler that rejects it. > For this patch: > > Reviewed-by: Laszlo Ersek <ler...@redhat.com> > > For the other two patches in the series: > > Acked-by: Laszlo Ersek <ler...@redhat.com> > Thank you Laszlo Ard. _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
