Reviewed-by: Yao, Jiewen <jiewen....@intel.com>

At same time, I suggest we move PcdTpm2HashMask to Dynamic section too, because 
now Tcg2Pei will set this PCD according to TPM2 device capability.

If you agree, I will check in both.

Thank you
Yao Jiewen


-----Original Message-----
From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com] 
Sent: Tuesday, August 18, 2015 12:29 PM
To: Yao, Jiewen; edk2-devel@lists.01.org
Cc: Zhang, Chao B; El-Haj-Mahmoud, Samer
Subject: RE: [edk2] [patch] SecurityPkg: Fixed build error due to FixedAtBuild 
PcdTcg2HashAlgorithmBitmap

Please see attached patch file. Can you help review it and check it in please?

Thanks,
--Samer




-----Original Message-----
From: Yao, Jiewen [mailto:jiewen....@intel.com] 
Sent: Saturday, August 15, 2015 1:10 AM
To: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hp.com>; edk2-devel@lists.01.org
Cc: Zhang, Chao B <chao.b.zh...@intel.com>; Yao, Jiewen <jiewen....@intel.com>
Subject: RE: [edk2] [patch] SecurityPkg: Fixed build error due to FixedAtBuild 
PcdTcg2HashAlgorithmBitmap

Sounds good to me.

Thank you
Yao Jiewen

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
El-Haj-Mahmoud, Samer
Sent: Saturday, August 15, 2015 8:55 AM
To: edk2-devel@lists.01.org
Cc: El-Haj-Mahmoud, Samer; Zhang, Chao B
Subject: [edk2] [patch] SecurityPkg: Fixed build error due to FixedAtBuild 
PcdTcg2HashAlgorithmBitmap

PcdTcg2HashAlgorithmBitmap is declared in a section that allows it to be Fixed 
or PatchableAtBuild, but there is code that sets it. This breaks the build on 
some platforms. Changed it to be PcdsDynamic and PcdsDynamicEx only.

Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahm...@hp.com>





Samer El-Haj-Mahmoud
System Firmware Architect
HP Servers 

el...@hp.com 
T +1.281.514.5973
C +1.512.659.1523
Hewlett-Packard Company
hp.com/go/proliant/uefi



_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to