Reviewed-by: Liming Gao <[email protected]> -----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of Eric Dong Sent: Friday, August 28, 2015 10:45 AM To: [email protected] Cc: Gao, Liming Subject: [edk2] [Patch] DisplayEngineDxe: Fixed calculate help string page count error.
Current logic has a corner case when a string has extra 1 line for the pages of help string. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong <[email protected]> Cc: Liming Gao <[email protected]> --- MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c index 938cce4..a391442 100644 --- a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c +++ b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c @@ -2947,11 +2947,11 @@ UiDisplayMenu ( // // Calculate the help page count. // if (HelpLine > 2 * RowCount - 2) { HelpPageCount = (HelpLine - RowCount + 1) / (RowCount - 2) + 1; - if ((HelpLine - RowCount + 1) % (RowCount - 2) > 1) { + if ((HelpLine - RowCount + 1) % (RowCount - 2) != 0) { HelpPageCount += 1; } } else { HelpPageCount = 2; } -- 1.9.5.msysgit.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
