Checked in code at r18350 -----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of Dong, Eric Sent: Friday, August 28, 2015 12:54 PM To: Wang, Sunny (HPS SW); [email protected] Cc: El-Haj-Mahmoud, Samer; Shifflett, Joseph Subject: Re: [edk2] [PATCH] MdeModulePkg: Remove unused variables from both UefiBootManagerLib and BdsDxe to fix GCC build.
Reviewed-by: Eric Dong <[email protected]> -----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of Wang, Sunny (HPS SW) Sent: Friday, August 28, 2015 12:40 PM To: [email protected] Cc: El-Haj-Mahmoud, Samer; Shifflett, Joseph Subject: [edk2] [PATCH] MdeModulePkg: Remove unused variables from both UefiBootManagerLib and BdsDxe to fix GCC build. Dear MdeModulePkg maintainers, Please find the attached patch that removes unused variables from both UefiBootManagerLib and BdsDxe to fix GCC build. MdeModulePkg: Remove unused variables from both UefiBootManagerLib and BdsDxe to fix GCC build. Cc: Samer El-Haj-Mahmoud <[email protected]<mailto:[email protected]>> Cc: Joseph Shifflett <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Sunny Wang <[email protected]> --- MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 3 +-- MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c | 3 +-- MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c index f68c25e..8f14cf6 100644 --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c @@ -1,6 +1,7 @@ /** @file Library functions which relates with booting. +(C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR> Copyright (c) 2011 - 2015, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License @@ -956,7 +957,6 @@ BmFindUsbDevice ( EFI_DEVICE_PATH_PROTOCOL *UsbIoDevicePath; EFI_USB_IO_PROTOCOL *UsbIo; UINTN Index; - UINTN UsbIoDevicePathSize; BOOLEAN Matched; ASSERT (UsbIoHandleCount != NULL); @@ -988,7 +988,6 @@ BmFindUsbDevice ( UsbIoDevicePath = DevicePathFromHandle (UsbIoHandles[Index]); Matched = FALSE; if (!EFI_ERROR (Status) && (UsbIoDevicePath != NULL)) { - UsbIoDevicePathSize = GetDevicePathSize (UsbIoDevicePath) - END_DEVICE_PATH_LENGTH; // // Compare starting part of UsbIoHandle's device path with ParentDevicePath. diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c b/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c index d197816..8f4b691 100644 --- a/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmDriverHealth.c @@ -1,6 +1,7 @@ /** @file Library functions which relates with driver health. +(C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR> Copyright (c) 2011 - 2015, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License @@ -295,7 +296,6 @@ EfiBootManagerGetDriverHealthInfo ( EFI_STATUS Status; UINTN NumHandles; EFI_HANDLE *DriverHealthHandles; - EFI_DRIVER_HEALTH_STATUS HealthStatus; UINTN DriverHealthIndex; EFI_HANDLE *Handles; UINTN HandleCount; @@ -313,7 +313,6 @@ EfiBootManagerGetDriverHealthInfo ( NumHandles = 0; HandleCount = 0; - HealthStatus = EfiDriverHealthStatusHealthy; Status = gBS->LocateHandleBuffer ( ByProtocol, diff --git a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c index 6ffb667..c889892 100644 --- a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c +++ b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c @@ -5,6 +5,7 @@ After DxeCore finish DXE phase, gEfiBdsArchProtocolGuid->BdsEntry will be invoked to enter BDS phase. +(C) Copyright 2015 Hewlett-Packard Development Company, L.P.<BR> Copyright (c) 2004 - 2015, Intel Corporation. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License @@ -144,7 +145,6 @@ BdsEnumerateBootOptions ( { EFI_STATUS Status; EFI_BOOT_MANAGER_LOAD_OPTION *BootOptions; - UINT16 NonBlockNumber; UINTN HandleCount; EFI_HANDLE *Handles; EFI_BLOCK_IO_PROTOCOL *BlkIo; @@ -220,7 +220,6 @@ BdsEnumerateBootOptions ( // // Parse simple file system not based on block io // - NonBlockNumber = 0; gBS->LocateHandleBuffer ( ByProtocol, &gEfiSimpleFileSystemProtocolGuid, -- 1.9.4.msysgit.2 Sunny Wang System Firmware Engineer HP Servers _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
