Looks good to me Reviewed-by: Feng Tian <[email protected]>
-----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of Laszlo Ersek Sent: Wednesday, September 16, 2015 10:57 To: [email protected] Cc: Ni, Ruiyu; Justen, Jordan L; Gabriel L. Somlo; Alexander Graf; Hannes Reinecke; Reza Jelveh Subject: [edk2] [PATCH v4 08/10] PcAtChipsetPkg: IdeControllerDxe: fix protocol usage hints in the INF file IdeControllerDxe installs EFI_IDE_CONTROLLER_INIT_PROTOCOL interface(s), and consumes PciIo. The comments in the INF file state the opposite at the moment, fix them. Cc: Alexander Graf <[email protected]> Cc: Reza Jelveh <[email protected]> Cc: Jordan Justen <[email protected]> Cc: Ruiyu Ni <[email protected]> Cc: Hannes Reinecke <[email protected]> Cc: Gabriel L. Somlo <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <[email protected]> --- PcAtChipsetPkg/Bus/Pci/IdeControllerDxe/IdeControllerDxe.inf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PcAtChipsetPkg/Bus/Pci/IdeControllerDxe/IdeControllerDxe.inf b/PcAtChipsetPkg/Bus/Pci/IdeControllerDxe/IdeControllerDxe.inf index 5e917c8..0184bf4 100644 --- a/PcAtChipsetPkg/Bus/Pci/IdeControllerDxe/IdeControllerDxe.inf +++ b/PcAtChipsetPkg/Bus/Pci/IdeControllerDxe/IdeControllerDxe.inf @@ -46,7 +46,7 @@ [LibraryClasses] UefiBootServicesTableLib [Protocols] - gEfiPciIoProtocolGuid ## BY_START - gEfiIdeControllerInitProtocolGuid ## TO_START + gEfiPciIoProtocolGuid ## TO_START + gEfiIdeControllerInitProtocolGuid ## BY_START [UserExtensions.TianoCore."ExtraFiles"] IdeControllerExtra.uni -- 1.8.3.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
