Samer El-Haj-Mahmoud [mailto:[email protected]] wrote:
]Sent: Wednesday, September 16, 2015 12:23 PM ]To: [email protected] ]Cc: Shifflett, Joseph <[email protected]>; Feng Tian <[email protected]> ]Subject: [edk2] [PATCH v2 1/1] When looping through all PCI functions, code should not look for functions 1-7 if ]function 0 is not present or if function 0 indicates the device is not multifunction. Prior to this fix, the code ]would use stale data in a buffer to d ] ]From: "Shifflett, Joseph" <[email protected]> ] ]Contributed-under: TianoCore Contribution Agreement 1.0 ]Signed-off-by: Samer El-Haj-Mahmoud <[email protected]> ]--- I see nothing wrong with the patch itself. On the other hand, Contributions.txt says: The entire first line should be less than ~70 characters In addition, there is no "Full-commit-message". Consider shortening the subject line and adding a full commit message. The full commit message could explain that the PCI specification states: They [multifunction devices] are also required to always implement function 0 in the device. Implementing other functions is optional and may be assigned in any order. What kind of problem is solved by this change? From what I can remember, one problem it solves is performance degradation caused master aborting on the many unneeded PCI config reads. Thanks, Scott _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
