On 09/24/15 22:21, Laszlo Ersek wrote: > On 09/24/15 22:07, Laszlo Ersek wrote: >> On 09/24/15 22:03, Laszlo Ersek wrote: >>> On 09/24/15 21:56, Carsey, Jaben wrote: >>>> Shumin, >>>> >>>> Can you review this? >>>> >>>> The update makes all the libs built when the package is built. (prevent >>>> future issue like where TFPT lib wouldn't build) >>> >>> I'm just about to send patches that will build TFTP into OVMF's and >>> ArmVirt*'s shell, so we too will catch such errors quickly. >>> >>> I am also reposting your patch "ShellPkg: Update tftp to build with >>> current tip" (in gitified form), because it needs a small fix for >>> building with gcc. >> >> Sigh. I can see the patch has been already committed. Okay, I'll include >> a patch that fixes it up then. > > Please do not commit patches to SVN with *significant changes* relative > to the last reviewed version. I compared the patch that is now committed > to SVN against your original posting (the one that Qiu Shumin reviewed > on the list), and there's a long list of differences: > > - IP4_CONFIG2_INTERFACE_INFO_NAME_LENGTH got prefixed with EFI_ > - HP's copyright was removed > - documentation of functions was updated > - various variables and fields were changed from UINTN to UINT64.
And this change actually breaks the Ia32 build, because it divides a UINT64 quantity with the "/" division operator. I'll send a patch for that too. Laszlo > - long lines were rewrapped > > These changes may all be justified, but they would have certainly > warranted a v2 post, and a new review. > > I understand this is tedious to do without git; hopefully once git is > universally used, noone will be tempted to cut corners like the above. > > Thanks > Laszlo > >> Thanks >> Laszlo >> >>> >>>> ShellPkg: ShellPkg DSC update >>>> >>>> Contributed-under: TianoCore Contribution Agreement 1.0 >>>> Signed-off-by: Jaben Carsey <[email protected]> >>> >>> Please consider moving to git; the list server is stripping away all >>> your attachments. >>> >>> Thanks >>> Laszlo >>> >>>> _______________________________________________ >>>> edk2-devel mailing list >>>> [email protected] >>>> https://lists.01.org/mailman/listinfo/edk2-devel >>>> >>> >>> _______________________________________________ >>> edk2-devel mailing list >>> [email protected] >>> https://lists.01.org/mailman/listinfo/edk2-devel >>> >> >> _______________________________________________ >> edk2-devel mailing list >> [email protected] >> https://lists.01.org/mailman/listinfo/edk2-devel >> > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
