Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -----Original Message----- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, September 24, 2015 2:30 PM > To: edk2-devel-01 <edk2-de...@ml01.01.org> > Cc: Carsey, Jaben <jaben.car...@intel.com> > Subject: [PATCH 1/3] ShellPkg: UefiShellTftpCommandLib: fix incompatible > pointer assignment > Importance: High > > Add the missing EFIAPI calling convention to the CheckPacket() function. > Without it, the gcc build breaks due to the incompatible pointer > assignment in "Mtftp4Token.CheckPacket = CheckPacket". > > Cc: Jaben Carsey <jaben.car...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > --- > ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c > b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c > index 2dc9287..4bb21aa 100644 > --- a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c > +++ b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c > @@ -197,6 +197,7 @@ DownloadFile ( > **/ > STATIC > EFI_STATUS > +EFIAPI > CheckPacket ( > IN EFI_MTFTP4_PROTOCOL *This, > IN EFI_MTFTP4_TOKEN *Token, > @@ -940,6 +941,7 @@ Error : > **/ > STATIC > EFI_STATUS > +EFIAPI > CheckPacket ( > IN EFI_MTFTP4_PROTOCOL *This, > IN EFI_MTFTP4_TOKEN *Token, > -- > 1.8.3.1 >
_______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
