Hi Matthew Thanks! It is good catch on code/spec mismatch. We start discussion in TCG on packed/unpacked structure.
Since current code is validated on Win8 and Win10, I suggest we rely on TCG to give final conclusion. Thank you Yao Jiewen -----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of Matthew Garrett Sent: Friday, September 25, 2015 8:43 AM To: [email protected] Subject: [edk2] Should TREE_BOOT_SERVICE_CAPABILITY be packed? The TCG PC Client Protocol spec for TPM2 devices says: "All structures defined in this specification are packed. Some compilers may insert space between fields of a structure to align them. This functionality SHALL be disabled, so structures are packed" The TCG_EVENT_HEADER and TrEE_EVENT structures are defined in TrEEProtocol.h as being packed, but TREE_BOOT_SERVICE_CAPABILITY_1_0 isn't. Since implementations appear to have shipped with this it's clearly impossible to make any changes now, but should we expect systems with the 1.1 structure (ie, with the additional information regarding PCR banks) to be packed or not? -- Matthew Garrett | [email protected] _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
