On 10/12/15 04:39, Gao, Liming wrote: > Reviewed-by: Liming Gao <liming....@intel.com>
Let's hope my comment arrives before this gets committed -- Yonghong, can you please state specific details in the subject and/or the body of the commit message? What is the error? What circumstances trigger it? How is it being fixed? "Fix an error" is one of the most generic terms for describing what software developers do. Thanks Laszlo > > -----Original Message----- > From: Zhu, Yonghong > Sent: Monday, October 12, 2015 9:52 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] BaseTools: Fixed an error reported during generating report > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Yonghong Zhu <yonghong....@intel.com> > --- > Source/Python/build/BuildReport.py | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/Source/Python/build/BuildReport.py > b/Source/Python/build/BuildReport.py > index 60e976c..bf5bb8f 100644 > --- a/Source/Python/build/BuildReport.py > +++ b/Source/Python/build/BuildReport.py > @@ -1234,16 +1234,17 @@ class FdRegionReport(object): > for Package in Pa.PackageList: > for (TokenCName, TokenSpaceGuidCName, DecType) in > Package.Pcds: > DecDefaultValue = Package.Pcds[TokenCName, > TokenSpaceGuidCName, DecType].DefaultValue > PlatformPcds[(TokenCName, TokenSpaceGuidCName)] = > DecDefaultValue > # > - # Collect PCDs defined in DSC common section > + # Collect PCDs defined in DSC file > # > - Platform = Wa.BuildDatabase[Wa.MetaFile, 'COMMON'] > - for (TokenCName, TokenSpaceGuidCName) in Platform.Pcds: > - DscDefaultValue = Platform.Pcds[(TokenCName, > TokenSpaceGuidCName)].DefaultValue > - PlatformPcds[(TokenCName, TokenSpaceGuidCName)] = DscDefaultValue > + for arch in Wa.ArchList: > + Platform = Wa.BuildDatabase[Wa.MetaFile, arch] > + for (TokenCName, TokenSpaceGuidCName) in Platform.Pcds: > + DscDefaultValue = Platform.Pcds[(TokenCName, > TokenSpaceGuidCName)].DefaultValue > + PlatformPcds[(TokenCName, TokenSpaceGuidCName)] = > DscDefaultValue > > # > # Add PEI and DXE a priori files GUIDs defined in PI specification. > # > self._GuidsDb["1B45CC0A-156A-428A-AF62-49864DA0E6E6"] = "PEI Apriori" > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
