On 2015-10-13 10:49:22, Michael Kinney wrote: > Add mappings to DebugAgentLib for SMM modules > to fix b uild breaks when SMM_REQUIRE and
'b uild' => 'build' > SOURCE_DEBUG_ENABLE are both set How about adding a period to the end of the sentence? Your line wrapping seems to be excessively small. (~50 characters). Too short of wrapping is better than too long, but I think 70~75 characters is about the best. (Git log adds 4 characters, so 75+4 still keeps that under 80 characters.) > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Michael Kinney <[email protected]> > --- > OvmfPkg/OvmfPkgIa32.dsc | 3 +++ > OvmfPkg/OvmfPkgIa32X64.dsc | 3 +++ Why did you not update the X64 build? My process for updating the dsc involves a 3-way diff of OvmfPkg/*.dsc, and I try to keep the differences minimal. If you update the X64 dsc, then Reviewed-by: Jordan Justen <[email protected]> > 2 files changed, 6 insertions(+) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index 18740b8..af02080 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -309,6 +309,9 @@ > !endif > > CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.inf > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > +!ifdef $(SOURCE_DEBUG_ENABLE) > + DebugAgentLib|SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf > +!endif > > [LibraryClasses.common.SMM_CORE] > PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index f12161a..2d9ba2f 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -314,6 +314,9 @@ > !endif > > CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.inf > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > +!ifdef $(SOURCE_DEBUG_ENABLE) > + DebugAgentLib|SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf > +!endif > > [LibraryClasses.common.SMM_CORE] > PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > -- > 1.9.5.msysgit.1 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
