On 10/13/15 15:36, Leif Lindholm wrote:
> On Tue, Oct 13, 2015 at 03:32:46PM +0200, Laszlo Ersek wrote:
>>>> // Install the Default FVB header if required
>>>> if (EFI_ERROR(Status)) {
>>>> // There is no valid header, so time to install one.
>>>> - DEBUG((EFI_D_ERROR,"NorFlashFvbInitialize: ERROR - The FVB Header is
>>>> not valid. Installing a correct one for this volume.\n"));
>>>> + DEBUG ((EFI_D_INFO, "%a: The FVB Header is not valid. Installing a "
>>>> + "correct one for this volume.\n", __FUNCTION__));
>>>
>>> While I approve of breaking output lines up to reviewable lengths,
>>> this one actually breaks up the message string itself - making
>>> tracking it down in the source more tedious. Could you either leave
>>> the message string whole, or break the two sentences into separate
>>> DEBUG statements?
>>
>> I'll break them up. I don't like overlong lines. :)
>
> Sure.
>
>> I assume you'd like to see the two sentences on separate lines in the
>> log output as well (so that noone is tempted to search for the full line
>> in the source). Is that right?
>
> Exactly, thanks!
>
>>> Do that and:
>>> Reviewed-by: Leif Lindholm <[email protected]>
I'll send a new version of the set soon; not picking up your R-b just
yet. I'd appreciate a quick skim. :)
Thanks!
Laszlo
>>
>> Thanks!
>> Laszlo
>>
>>>
>>>>
>>>> // Erase all the NorFlash that is reserved for variable storage
>>>> FvbNumLba = (PcdGet32(PcdFlashNvStorageVariableSize) +
>>>> PcdGet32(PcdFlashNvStorageFtwWorkingSize) +
>>>> PcdGet32(PcdFlashNvStorageFtwSpareSize)) / Instance->Media.BlockSize;
>>>>
>>>> Status = FvbEraseBlocks (&Instance->FvbProtocol, (EFI_LBA)0,
>>>> FvbNumLba, EFI_LBA_LIST_TERMINATOR);
>>>> if (EFI_ERROR(Status)) {
>>>> return Status;
>>>> }
>>>>
>>>> // Install all appropriate headers
>>>> --
>>>> 1.8.3.1
>>>>
>>>>
>>
> _______________________________________________
> edk2-devel mailing list
> [email protected]
> https://lists.01.org/mailman/listinfo/edk2-devel
>
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
