On 10/14/15 15:30, Ard Biesheuvel wrote: > On 14 October 2015 at 13:30, Laszlo Ersek <[email protected]> wrote: >> Addressing v1 review feedback, and adding an early hello message for >> ARM. Changes are noted per patch. >> > > I don't think we need this on most ARM platforms (QEMU being the > exception, though) > > ArmPlatformPkg/PrePi/PrePi.c:119: CharCount = AsciiSPrint > (Buffer,sizeof (Buffer),"UEFI firmware (version %s built at %a on > %a)\n\r", > ArmPlatformPkg/PrePi/PrePi.c-120- > (CHAR16*)PcdGetPtr(PcdFirmwareVersionString), __TIME__, __DATE__); > ArmPlatformPkg/PrePi/PrePi.c-121- SerialPortWrite ((UINT8 *) Buffer, > CharCount); > -- > ArmVirtPkg/PrePi/PrePi.c:128: CharCount = AsciiSPrint (Buffer,sizeof > (Buffer),"UEFI firmware (version %s built at %a on %a)\n\r", > ArmVirtPkg/PrePi/PrePi.c-129- > (CHAR16*)PcdGetPtr(PcdFirmwareVersionString), __TIME__, __DATE__); > ArmVirtPkg/PrePi/PrePi.c-130- SerialPortWrite ((UINT8 *) Buffer, CharCount);
I'm fine dropping the PrePi patch -- I suspected there could be differences between PrePi and PrePeiCore, so I split those changes in two patches. If necessary I can make a note in the PrePeiCore patch that PrePi has a similar feature already, and I can rename the PCD too so that its PrePeiCore-nature is clear. Do you have a different idea? Thanks Laszlo > > > >> Testing on Xen and/or physical ARM|AARCH64 platforms would be >> appreciated. (The patches should be easy to apply from the mailing list >> -- no new files are created, so just use "git am --keep-cr".) >> >> Thanks! >> Laszlo >> >> Cc: Ard Biesheuvel <[email protected]> >> Cc: Liming Gao <[email protected]> >> Cc: Drew Jones <[email protected]> >> Cc: Leif Lindholm <[email protected]> >> Cc: Yehuda Yitschak <[email protected]> >> Cc: Star Zeng <[email protected]> >> >> Laszlo Ersek (8): >> ArmPlatformPkg: NorFlashDxe: mellow DEBUG messages about flash reinit >> MdeModulePkg: FaultTolerantWriteDxe: mellow DEBUGs about workspace >> reinit >> MdeModulePkg: FaultTolerantWriteDxe: clean up some "success" messages >> MdeModulePkg: SmbiosDxe: soften DEBUG messages about table >> reallocation >> ArmPlatformPkg: introduce fixed PCD for early hello message >> ArmPlatformPkg: PrePeiCore: write early hello message to the serial >> port >> ArmPlatformPkg: PrePi: write early hello message to the serial port >> ArmVirtPkg: set early hello message >> >> ArmPlatformPkg/ArmPlatformPkg.dec | 7 >> +++++++ >> ArmVirtPkg/ArmVirt.dsc.inc | 1 + >> ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 2 ++ >> ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 2 ++ >> ArmPlatformPkg/PrePi/PeiMPCore.inf | 2 ++ >> ArmPlatformPkg/PrePi/PeiUniCore.inf | 2 ++ >> ArmPlatformPkg/PrePeiCore/PrePeiCore.h | 1 + >> ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashFvbDxe.c | 19 >> +++++++++++++------ >> ArmPlatformPkg/PrePeiCore/MainMPCore.c | 5 +++++ >> ArmPlatformPkg/PrePeiCore/MainUniCore.c | 5 +++++ >> ArmPlatformPkg/PrePi/MainMPCore.c | 5 +++++ >> ArmPlatformPkg/PrePi/MainUniCore.c | 5 +++++ >> MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWrite.c | 6 >> +++--- >> MdeModulePkg/Universal/FaultTolerantWriteDxe/FtwMisc.c | 6 >> ++++-- >> MdeModulePkg/Universal/FaultTolerantWriteDxe/UpdateWorkingBlock.c | 2 +- >> MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c | 6 >> ++++-- >> 16 files changed, 62 insertions(+), 14 deletions(-) >> >> -- >> 1.8.3.1 >> _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
