On Wed, Oct 14, 2015 at 04:29:28PM +0800, Eric Dong wrote: > Cc: Liming Gao <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Eric Dong <[email protected]>
Hi Eric, There appears to be no commit message here. I guess the addition of this optional ';' is simply to update this example to use the improved syntax added by 1/2 - to encourage people to start using it. So can you just mention that? Regards, Leif > --- > MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr > b/MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr > index bd28797..c48b06a 100644 > --- a/MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr > +++ b/MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr > @@ -213,11 +213,11 @@ formset > option text = STRING_TOKEN(STR_BOOT_OPTION2), value = 2, > flags = 0; > option text = STRING_TOKEN(STR_BOOT_OPTION1), value = 1, > flags = 0; > option text = STRING_TOKEN(STR_BOOT_OPTION3), value = 3, > flags = 0; > suppressif ideqval MyIfrNVData.BootOrderLarge == 0; > option text = STRING_TOKEN(STR_BOOT_OPTION4), value = 4, > flags = 0; > - endif > + endif; > endlist; > > // > // label should be paired with each other > // > @@ -261,11 +261,11 @@ formset > flags = RESET_REQUIRED, > option text = STRING_TOKEN(STR_ONE_OF_TEXT1), value = 0, flags = 0; > option text = STRING_TOKEN(STR_ONE_OF_TEXT2), value = 1, flags = > DEFAULT; > warningif prompt = STRING_TOKEN(STR_WARNING_POPUP), timeout = 5, > ideqval MyIfrNVData.TestLateCheck == 0 > - endif > + endif; > > endoneof; > > oneof varid = MyIfrNVData.TestLateCheck2, > prompt = STRING_TOKEN(STR_TEST_OPCODE2), > @@ -274,11 +274,11 @@ formset > option text = STRING_TOKEN(STR_ONE_OF_TEXT1), value = 0, flags = > DEFAULT; > option text = STRING_TOKEN(STR_ONE_OF_TEXT2), value = 1, flags = 0; > > inconsistentif prompt = STRING_TOKEN(STR_ERROR_POPUP), > ideqid MyIfrNVData.TestLateCheck == MyIfrNVData.TestLateCheck2 > - endif > + endif; > > endoneof; > > oneof varid = MyIfrNVData.QuestionAboutTreeHugging, > prompt = STRING_TOKEN(STR_ONE_OF_PROMPT_KEYWORD), > @@ -299,11 +299,11 @@ formset > key = 0x1236, > minsize = 6, > maxsize = 40, > inconsistentif prompt = > STRING_TOKEN(STR_STRING_CHECK_ERROR_POPUP), > pushthis != stringref(STRING_TOKEN(STR_STRING_CHECK)) > - endif > + endif; > endstring; > > // > // Define a numeric (EFI_IFR_NUMERIC) > // > @@ -332,11 +332,11 @@ formset > ideqval MyIfrNVData.HowOldAreYouInYearsManual == 99 > OR > ideqid MyIfrNVData.HowOldAreYouInYearsManual == > MyEfiVar.Field8 > OR > ideqvallist MyIfrNVData.HowOldAreYouInYearsManual == 1 3 5 7 > - endif > + endif; > > endnumeric; > > numeric varid = MyEfiVar.Field8, // Reference of > EFI variable storage > questionid = 0x1111, > @@ -537,20 +537,20 @@ formset > > inconsistentif prompt = STRING_TOKEN(STR_ERROR_POPUP), > ideqval Date.Day == 31 > AND > ideqvallist Date.Month == 2 4 6 9 11 > - endif > + endif; > > // > // If the day is 30 AND month is 2 > // > inconsistentif prompt = STRING_TOKEN(STR_ERROR_POPUP), > ideqval Date.Day == 30 > AND > ideqval Date.Month == 2 > - endif > + endif; > > // > // If the day is 29 AND month is 2 AND it year is NOT a leapyear > // > inconsistentif prompt = STRING_TOKEN(STR_ERROR_POPUP), > @@ -558,11 +558,11 @@ formset > AND > ideqval Date.Month == 2 > AND > NOT > ideqvallist Date.Year == 2004 2008 20012 20016 2020 2024 2028 2032 > 2036 > - endif > + endif; > > enddate; > > text > help = STRING_TOKEN(STR_SAVE_CURRENT_AND_EXIT), > -- > 1.9.5.msysgit.1 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
