Please put the 'if' statement on its own line. -Erik
-----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of Qiu Shumin Sent: Tuesday, October 13, 2015 10:00 PM To: [email protected] Cc: Carsey, Jaben <[email protected]>; Qiu, Shumin <[email protected]> Subject: [edk2] [PATCH] ShellPkg: Use safe string functions to refine Tftp.c code. Cc: Jaben Carsey <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin <[email protected]> --- ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c index 4bb21aa..02099fe 100644 --- a/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c +++ b/ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c @@ -955,6 +955,7 @@ CheckPacket ( UINTN Index; UINTN LastStep; UINTN Step; + EFI_STATUS Status; if ((NTOHS (Packet->OpCode)) != EFI_MTFTP4_OPCODE_DATA) { return EFI_SUCCESS; @@ -984,7 +985,10 @@ CheckPacket ( ShellPrintEx (-1, -1, L"%s", mTftpProgressDelete); - StrCpy (Progress, mTftpProgressFrame); + Status = StrCpyS (Progress, TFTP_PROGRESS_MESSAGE_SIZE, + mTftpProgressFrame); if (EFI_ERROR(Status)) { + return Status; + } for (Index = 1; Index < Step; Index++) { Progress[Index] = L'='; } -- 1.9.5.msysgit.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
