On 10/15/15 01:26, Michael Kinney wrote: > Add module that initializes a CPU for the SMM environment and > installs the first level SMI handler. This module along with the > SMM IPL and SMM Core provide the services required for > DXE_SMM_DRIVERS to register hardware and software SMI handlers. > > CPU specific features are abstracted through the SmmCpuFeaturesLib > > Platform specific features are abstracted through the > SmmCpuPlatformHookLib > > Several PCDs are added to enable/disable features and configure > settings for the PiSmmCpuDxeSmm module > > Changes between [PATCH v1] and [PATCH v2]: > 1) Swap PTE init order for QEMU compatibility. > Current PTE initialization algorithm works on HW but breaks QEMU > emulator. Update the PTE initialization order to be compatible > with both. > 2) Update comment block that describes 32KB SMBASE alignment requirement > to match contents of Intel(R) 64 and IA-32 Architectures Software > Developer's Manual > 3) Remove BUGBUG comment and call to ClearSmi() that is not required. > SMI should be cleared by root SMI handler. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Michael Kinney <[email protected]> > Cc: Laszlo Ersek <[email protected]> > Cc: Paolo Bonzini <[email protected]>
This is obviously too big for me to review in depth, but I'll ACK it. First however, please append the following three lines to the very end of the commit message: [[email protected]: InitPaging: prepare PT before filling in PDE] Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Paolo Bonzini <[email protected]> With that change: Acked-by: Laszlo Ersek <[email protected]> Thank you for this work!!! Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
