Ah, yes, you are right! Thank you! I will resend patch.
-----Original Message----- From: Mike Maslenkin [mailto:[email protected]] Sent: Monday, October 26, 2015 5:31 PM To: Yao, Jiewen Cc: [email protected]; Ma, Maurice; Rangarajan, Ravi P Subject: Re: [edk2] [patch] Do not deadloop if Microcode not found in FspTempRamInit. On Mon, 2015-10-26 at 12:39 +0800, jiewen yao wrote: > diff --git > a/IntelFspWrapperPkg/Library/SecPeiFspPlatformSecLibSample/Ia32/SecEnt > ry.asm > b/IntelFspWrapperPkg/Library/SecPeiFspPlatformSecLibSample/Ia32/SecEnt > ry.asm > index 0e0c5c5..3c0bca3 100644 > --- > a/IntelFspWrapperPkg/Library/SecPeiFspPlatformSecLibSample/Ia32/SecEnt > ry.asm > +++ b/IntelFspWrapperPkg/Library/SecPeiFspPlatformSecLibSample/Ia32/Se > +++ cEntry.asm > @@ -220,12 +220,22 @@ FspHeaderFound: > jmp eax > > TempRamInitDone: > - cmp eax, 0 > + cmp eax, 8000000Eh ;Check if EFI_NOT_FOUND returned. Error code for > Microcode Update not found. > + xor eax, eax > + je CallSecFspInit ;If microcode not found, don't hang, but continue. > + > + cmp eax, 0 ;Check if EFI_SUCCESS retuned. > jnz FspApiFailed Hello jiewen, would this condition be always true? 'xor eax, eax' instruction will set ZF flag, so you lose the comparison result. _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
