On 2015/10/28 9:44, Ard Biesheuvel wrote:
On 28 October 2015 at 10:33, Star Zeng <[email protected]> wrote:
This patch does below things.
1. Smbios3Table used as SmbiosTable wrongly after SmbiosTable got from
configuration table.
2. Correct the return comments of entrypoint function.
3. Add parameters' comments for MeasureSmbiosTable().
4. Remove the tailing space from SmbiosMeasurementDxe.c.
5. Correct the Protocols and Guids usage comments in SmbiosMeasurementDxe.inf.
6. Add (VOID **) typecast in LocateProtocol call for GCC build failure.
7. Use EFI_D_VERBOSE instead of EFI_D_INFO in InternalDumpData() and
InternalDumpHex().
8. Use correct VendorGuid and VendorTable to measure.
If you need a numbered list to summarize the changes you are making in
a patch, that is usually a strong hint that you should split it into
several patches. You have a bug fixes (1,8), comment fixes (2,3,5), a
functional change (7), a build fix (6) and a whitespace fix (4), so
you should split this into 5 or 6 patches at least.
Good comments.
Just followed your suggestion to resend the split patch set.
Thanks,
Star
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
