When StringId is not 0, String returned from GetSmbiosStringById is expected to 
non-NULL.
Add ASSERT (String != NULL); to ensure this.

Cc: Jiewen Yao <[email protected]>
Cc: Shumin Qiu <[email protected]>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <[email protected]>
---
 MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c 
b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c
index 5aafabf..f9e0196 100644
--- a/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c
+++ b/MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.c
@@ -286,6 +286,7 @@ FilterSmbiosEntry (
           if (StringId != 0) {
             // set ' ' for string field
             String = GetSmbiosStringById (TableEntry, StringId, &StringLen);
+            ASSERT (String != NULL);
             //DEBUG ((EFI_D_INFO,"StrId(0x%x)-%a(%d)\n", StringId, String, 
StringLen));
             SetMem (String, StringLen, ' ');
           }
-- 
1.9.5.msysgit.0

_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to