Hi  Carl,

Could you let me know your environment info, os info, etc.  actually I can't 
reproduce the issue. So please help me to reproduce it, thanks.

Best Regards,

Zhu Yonghong

-----Original Message-----
From: edk2-devel [mailto:[email protected]] On Behalf Of Miller, 
Carl H
Sent: Thursday, October 29, 2015 9:58 PM
To: [email protected]
Subject: [edk2] RE enquote PATH: edk2-devel Digest, Vol 4, Issue 214

Zhu Yonghong,
the error you might see would depend on the particular setting of your PATH 
variable at time of running toolsetup, for instance, my PATH contained the 
string "C:\Program Files (x86)\Cmake\bin" without the quotes. when i ran 
toolsetup, i got an error to the effect of "unknown command '\Cmake\bin' "....

------------------------------

Message: 6
Date: Thu, 29 Oct 2015 08:58:55 +0000
From: "Zhu, Yonghong" <[email protected]>
To: "Miller, Carl H" <[email protected]>, "[email protected]"
        <[email protected]>
Cc: "Gao, Liming" <[email protected]>
Subject: Re: [edk2] PATCH BaseTools/toolsetup.bat : enquote PATH
        reassignment
Message-ID:
        <b9726d6dccfb8b4ca276a9169b02216d0140f...@shsmsx103.ccr.corp.intel.com>
        
Content-Type: text/plain; charset="us-ascii"

Hi Carl,

May I know the detail error we would meet if we don't add the quotes ?

Best Regards,

Zhu Yonghong

From: Miller, Carl H [mailto:[email protected]]
Sent: Wednesday, October 28, 2015 11:03 PM
To: [email protected]
Cc: Zhu, Yonghong; Gao, Liming
Subject: PATCH BaseTools/toolsetup.bat : enquote PATH reassignment

add quotes around updating of the PATH env. var. to avoid errors when existing 
path contains spaces.

Cc: M: Yonghong Zhu <[email protected]<mailto:[email protected]>>
       M: Liming Gao <[email protected]<mailto:[email protected]>>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Thompson, James J 
<[email protected]<mailto:[email protected]>>
diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat index 
59874c5..e90e28e 100755
--- a/BaseTools/toolsetup.bat
+++ b/BaseTools/toolsetup.bat
@@ -322,10 +322,10 @@ goto end
       echo !!! WARNING !!! Will not be able to compile Python programs to .exe
       echo Will setup environment to run Python scripts directly.
       echo.
-      set PATH=%BASETOOLS_PYTHON_SOURCE%\Trim;%PATH%
-      set PATH=%BASETOOLS_PYTHON_SOURCE%\GenFds;%PATH%
-      set PATH=%BASETOOLS_PYTHON_SOURCE%\build;%PATH%
-      set PATHEXT=%PATHEXT%;.py
+     set PATH="%BASETOOLS_PYTHON_SOURCE%\Trim;%PATH%"
+     set PATH="%BASETOOLS_PYTHON_SOURCE%\GenFds;%PATH%"
+     set PATH="%BASETOOLS_PYTHON_SOURCE%\build;%PATH%"
+     set PATHEXT=%PATHEXT%;.py
     )
   )


_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to