Yes, you are right, the comments should be "HTTPClient" in both ip4 and ip6 stack.
Thanks -----Original Message----- From: Gary Ching-Pang Lin [mailto:[email protected]] Sent: Tuesday, November 03, 2015 3:37 PM To: Zhang, Lubo Cc: Ye, Ting; [email protected]; Wu, Jiaxin; Fu, Siyuan Subject: Re: [edk2] [patch] NetworkPkg:Enable Http Boot over Ipv6 stack On Tue, Nov 03, 2015 at 03:20:29PM +0800, Gary Ching-Pang Lin wrote: > On Mon, Nov 02, 2015 at 10:31:13AM +0800, Zhang Lubo wrote: > > This patch is used to add new features to support Http boot over ipv6 stack. > > > Hi Lubo, > > In NetworkPkg/HttpBootDxe/HttpBootDhcp6.c::HttpBootParseDhcp6Packet() > the section to check if the packet is a Http offer, it checks the > dhcp6 option 3 > (HTTP_BOOT_DHCP6_IDX_VENDOR_CLASS) instead of the option 60 > (HTTP_BOOT_DHCP6_OPT_BOOT_FILE_PARAM) which is mentioned in UEFI 2.5 p.1211. Oops, I read the wrong page. It's for IPv4. Ignore my comment here. Sorry for the noise. Gary Lin > The string in the comment is also wrong. It should be "HTTPClient" > instead of "HttpClient". > > Cheers, > > Gary Lin > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
