Hi Jordan,
Yes, you are right! It could make commit message subject clearer. I saw
the related information mentioned in
https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format
This is my mistake. Thanks for the reminder. I will do that next time.
Regards,
Sunny Wang
-----Original Message-----
From: Jordan Justen [mailto:jordan.l.jus...@intel.com]
Sent: Tuesday, November 03, 2015 3:57 PM
To: Wang, Sunny (HPS SW); Ni, Ruiyu
Cc: Tian, Feng; edk2-devel@lists.01.org
Subject: Re: [edk2] [PATCH] MdeModulePkg: Fix memory leak issues
Importance: High
Although this was already committed, I had one comment for the future.
In the patch commit message subject, I think you should have included
UefiBootManagerLib.
MdeModulePkg UefiBootManagerLib: Fix memory leak issues
-Jordan
On 2015-11-02 02:56:14, Wang, Sunny (HPS SW) wrote:
> Hi Ray,
> Good catch! Thanks. :)
> I updated patch for this. Please help to review it again.
>
> Regards,
> Sunny Wang
>
> -----Original Message-----
> From: Ni, Ruiyu [mailto:ruiyu...@intel.com]
> Sent: Saturday, October 31, 2015 6:59 AM
> To: Wang, Sunny (HPS SW)
> Cc: Tian, Feng; El-Haj-Mahmoud, Samer; edk2-devel@lists.01.org
> Subject: RE: [edk2] [PATCH] MdeModulePkg: Fix memory leak issues
> Importance: High
>
> Sunny,
> You could move the two FreePool (FullInstance) to one place which is under
> the LocateDevicePath() call to make the change smaller a bit.
> What do you think?
>
> Thanks,
> Ray
>
> -----Original Message-----
> From: Wang, Sunny (HPS SW) [mailto:sunnyw...@hpe.com]
> Sent: Friday, October 30, 2015 6:21 PM
> To: Ni, Ruiyu <ruiyu...@intel.com>
> Cc: Tian, Feng <feng.t...@intel.com>; El-Haj-Mahmoud, Samer
> <samer.el-haj-mahm...@hpe.com>; Wang, Sunny (HPS SW)
> <sunnyw...@hpe.com>; edk2-devel@lists.01.org
> Subject: RE: [edk2] [PATCH] MdeModulePkg: Fix memory leak issues
>
> Hi Ray,
> Are you the owner of this module (UefiBootManagerLib)? If so, could
> you help to review and commit it? If not, could you tell me who is the
> owner?
> In addition, the attached patch would also need your help to get
> committed. Thanks!
>
> Regards,
> Sunny Wang
>
> -----Original Message-----
> From: Tian, Feng [mailto:feng.t...@intel.com]
> Sent: Thursday, October 29, 2015 8:21 AM
> To: El-Haj-Mahmoud, Samer; Wang, Sunny (HPS SW);
> edk2-devel@lists.01.org
> Cc: Tian, Feng
> Subject: RE: [edk2] [PATCH] MdeModulePkg: Fix memory leak issues
> Importance: High
>
> I will let module owner review and commit it.
>
> Thanks
> Feng
>
> -----Original Message-----
> From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com]
> Sent: Wednesday, October 28, 2015 22:58
> To: Wang, Sunny (HPS SW); edk2-devel@lists.01.org; Tian, Feng
> Subject: RE: [edk2] [PATCH] MdeModulePkg: Fix memory leak issues
>
> + MdeModuklePkg maintainers.
>
> Can someone help by committing this please?
>
>
>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> El-Haj-Mahmoud, Samer
> Sent: Tuesday, October 27, 2015 10:14 AM
> To: Wang, Sunny (HPS SW) <sunnyw...@hpe.com>; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] MdeModulePkg: Fix memory leak issues
>
> Reviewed-by: Samer El-Haj-Mahmoud <el...@hpe.com>
>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Wang, Sunny (HPS SW)
> Sent: Tuesday, October 27, 2015 3:47 AM
> To: edk2-devel@lists.01.org
> Cc: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>
> Subject: [edk2] [PATCH] MdeModulePkg: Fix memory leak issues
>
> Fix memory leak issues
>
> Contributed-under: TianoCore Contribution Agreement 1.0
>
> Signed-off-by: Sunny Wang <sunnyw...@hpe.com>
> ---
> MdeModulePkg/Library/UefiBootManagerLib/BmConsole.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmConsole.c
> b/MdeModulePkg/Library/UefiBootManagerLib/BmConsole.c
> index 86b4fac..0830166 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/BmConsole.c
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmConsole.c
> @@ -2,6 +2,7 @@
> Library functions which contain all the code to connect console device.
>
> Copyright (c) 2011 - 2015, Intel Corporation. All rights
> reserved.<BR>
> +(C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
> This program and the accompanying materials are licensed and made available
> under the terms and conditions of the BSD License which accompanies this
> distribution. The full text of the license may be found at @@ -301,6 +302,7
> @@ BmUpdateSystemTableConsole (
> EFI_DEVICE_PATH_PROTOCOL *FullDevicePath;
> EFI_DEVICE_PATH_PROTOCOL *VarConsole;
> EFI_DEVICE_PATH_PROTOCOL *Instance;
> + EFI_DEVICE_PATH_PROTOCOL *FullInstance;
> VOID *Interface;
> EFI_HANDLE NewHandle;
> EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL *TextOut; @@ -354,6 +356,7 @@
> BmUpdateSystemTableConsole (
> //
> // Find console device handle by device path instance
> //
> + FullInstance = Instance;
> Status = gBS->LocateDevicePath (
> ConsoleGuid,
> &Instance,
> @@ -383,15 +386,18 @@ BmUpdateSystemTableConsole (
> TextOut->SetMode (TextOut, 0);
> }
> }
> + FreePool (FullDevicePath);
> + FreePool (FullInstance);
> return TRUE;
> }
> }
> -
> + FreePool (FullInstance);
> } while (Instance != NULL);
>
> //
> // No any available console devcie found.
> //
> + FreePool (FullDevicePath);
> return FALSE;
> }
>
> --
> 2.5.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>
>
>
>
> Fix memory leak issues
>
> Contributed-under: TianoCore Contribution Agreement 1.0
>
> Signed-off-by: Sunny Wang <sunnyw...@hpe.com>
> ---
> MdeModulePkg/Library/UefiBootManagerLib/BmConsole.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmConsole.c
> b/MdeModulePkg/Library/UefiBootManagerLib/BmConsole.c
> index 86b4fac..a13917b 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/BmConsole.c
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmConsole.c
> @@ -2,6 +2,7 @@
> Library functions which contain all the code to connect console device.
>
> Copyright (c) 2011 - 2015, Intel Corporation. All rights
> reserved.<BR>
> +(C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
> This program and the accompanying materials are licensed and made
> available under the terms and conditions of the BSD License which
> accompanies this distribution. The full text of the license may be
> found at @@ -301,6 +302,7 @@ BmUpdateSystemTableConsole (
> EFI_DEVICE_PATH_PROTOCOL *FullDevicePath;
> EFI_DEVICE_PATH_PROTOCOL *VarConsole;
> EFI_DEVICE_PATH_PROTOCOL *Instance;
> + EFI_DEVICE_PATH_PROTOCOL *FullInstance;
> VOID *Interface;
> EFI_HANDLE NewHandle;
> EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL *TextOut; @@ -354,11 +356,13 @@
> BmUpdateSystemTableConsole (
> //
> // Find console device handle by device path instance
> //
> + FullInstance = Instance;
> Status = gBS->LocateDevicePath (
> ConsoleGuid,
> &Instance,
> &NewHandle
> );
> + FreePool (FullInstance);
> if (!EFI_ERROR (Status)) {
> //
> // Get the console protocol on this console device handle @@
> -383,6 +387,7 @@ BmUpdateSystemTableConsole (
> TextOut->SetMode (TextOut, 0);
> }
> }
> + FreePool (FullDevicePath);
> return TRUE;
> }
> }
> @@ -392,6 +397,7 @@ BmUpdateSystemTableConsole (
> //
> // No any available console devcie found.
> //
> + FreePool (FullDevicePath);
> return FALSE;
> }
>
> --
> 2.5.0.windows.1
>
>
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
