Hi Ray,
This patch overall looks good to me. I just made a minor comment in
this patch. You can search "[Sunny]" to find it out.
Regards,
Sunny Wang
-----Original Message-----
From: edk2-devel [mailto:[email protected]] On Behalf Of Ruiyu Ni
Sent: Monday, November 02, 2015 7:34 PM
To: [email protected]
Cc: Ruiyu Ni; Eric Dong
Subject: [edk2] [Patch 09/11] MdeModulePkg: Use UefiSpec.h defined macro to
replace L"xxx" string
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <[email protected]>
Cc: Eric Dong <[email protected]>
---
MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c
b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c
index c889892..4154d41 100644
--- a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c
+++ b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c
@@ -672,7 +672,7 @@ BdsFormalizeOSIndicationVariable (
//
OsIndicationSupport = EFI_OS_INDICATIONS_BOOT_TO_FW_UI;
Status = gRT->SetVariable (
- L"OsIndicationsSupported",
+ EFI_OS_INDICATIONS_SUPPORT_VARIABLE_NAME,
&gEfiGlobalVariableGuid,
EFI_VARIABLE_BOOTSERVICE_ACCESS |
EFI_VARIABLE_RUNTIME_ACCESS,
sizeof(UINT64),
@@ -694,7 +694,7 @@ BdsFormalizeOSIndicationVariable (
Attributes = 0;
DataSize = sizeof(UINT64);
Status = gRT->GetVariable (
- L"OsIndications",
+ EFI_OS_INDICATIONS_VARIABLE_NAME,
&gEfiGlobalVariableGuid,
&Attributes,
&DataSize,
@@ -711,7 +711,7 @@ BdsFormalizeOSIndicationVariable (
DEBUG ((EFI_D_ERROR, "[Bds] Unformalized OsIndications variable exists.
Delete it\n"));
Status = gRT->SetVariable (
- L"OsIndications",
+ EFI_OS_INDICATIONS_VARIABLE_NAME,
&gEfiGlobalVariableGuid,
0,
0,
@@ -737,9 +737,9 @@ BdsFormalizeEfiGlobalVariable (
//
// Validate Console variable.
//
- BdsFormalizeConsoleVariable (L"ConIn");
- BdsFormalizeConsoleVariable (L"ConOut");
- BdsFormalizeConsoleVariable (L"ErrOut");
+ BdsFormalizeConsoleVariable (EFI_CON_IN_VARIABLE_NAME);
+ BdsFormalizeConsoleVariable (EFI_CON_OUT_VARIABLE_NAME);
+ BdsFormalizeConsoleVariable (EFI_ERR_OUT_VARIABLE_NAME);
[Sunny] Are these two lines above having the wrong indent?
//
// Validate OSIndication related variable.
@@ -1045,7 +1045,7 @@ BdsEntry (
//
DataSize = sizeof (UINT64);
Status = gRT->GetVariable (
- L"OsIndications",
+ EFI_OS_INDICATIONS_VARIABLE_NAME,
&gEfiGlobalVariableGuid,
NULL,
&DataSize,
@@ -1062,7 +1062,7 @@ BdsEntry (
if (BootFwUi) {
OsIndication &= ~((UINT64) EFI_OS_INDICATIONS_BOOT_TO_FW_UI);
Status = gRT->SetVariable (
- L"OsIndications",
+ EFI_OS_INDICATIONS_VARIABLE_NAME,
&gEfiGlobalVariableGuid,
EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS |
EFI_VARIABLE_NON_VOLATILE,
sizeof(UINT64),
--
1.9.5.msysgit.1
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
