Mike:
In Build.py, after it converts WorkspaceDir, it also set it into its
os.environ["WORKSPACE"]. And, I verify this patch that prints the same style
for those envs.
WorkspaceDir = os.path.normcase(os.path.normpath(os.environ["WORKSPACE"]))
if not os.path.exists(WorkspaceDir):
EdkLogger.error("build", FILE_NOT_FOUND, "WORKSPACE doesn't exist",
ExtraData="%s" % WorkspaceDir)
elif ' ' in WorkspaceDir:
EdkLogger.error("build", FORMAT_NOT_SUPPORTED, "No space is allowed in
WORKSPACE path",
ExtraData=WorkspaceDir)
os.environ["WORKSPACE"] = WorkspaceDir
Thanks
Liming
-----Original Message-----
From: Kinney, Michael D
Sent: Friday, November 06, 2015 9:14 AM
To: Gao, Liming; [email protected]; Kinney, Michael D
Subject: RE: [edk2] [Patch] BaseTools: Print PACKAGES_PATH build environment if
it is set.
Liming,
That is the assignment of a Python variable WorkspaceDir, but the lines to do
prints are not consistent.
EdkLogger.quiet("%-16s = %s" % ("WORKSPACE",os.environ["WORKSPACE"]))
EdkLogger.quiet("%-16s = %s" % ("PACKAGES_PATH",
os.path.normcase(os.path.normpath(os.environ["PACKAGES_PATH"]))))
Mike
>-----Original Message-----
>From: Gao, Liming
>Sent: Thursday, November 05, 2015 4:58 PM
>To: Kinney, Michael D; [email protected]
>Cc: Gao, Liming
>Subject: RE: [edk2] [Patch] BaseTools: Print PACKAGES_PATH build
>environment if it is set.
>
>Mike:
> WORKSPACE env has been converted in the previous logic. Build.py line
>101, WorkspaceDir =
>os.path.normcase(os.path.normpath(os.environ["WORKSPACE"])).
> Here, I convert PACKAGES_PATH and EDK_TOOLS_BIN to be consistent
>print style with WORKSPACE env.
>
>Thanks
>Liming
>-----Original Message-----
>From: Kinney, Michael D
>Sent: Thursday, November 05, 2015 7:46 AM
>To: Gao, Liming; [email protected]; Kinney, Michael D
>Subject: RE: [edk2] [Patch] BaseTools: Print PACKAGES_PATH build
>environment if it is set.
>
>Liming,
>
>Why do you a different method than WORKSPACE to display the
>PACKAGES_PATH and EDK_TOOLS_BIN environment variables?
>
>Thanks,
>
>Mike
>
>>-----Original Message-----
>>From: edk2-devel [mailto:[email protected]] On Behalf Of
>>Liming Gao
>>Sent: Tuesday, November 03, 2015 5:15 PM
>>To: [email protected]
>>Subject: [edk2] [Patch] BaseTools: Print PACKAGES_PATH build
>>environment if it is set.
>>
>>Print the optional build environment PACKAGES_PATH and EDK_TOOLS_BIN.
>>
>>Contributed-under: TianoCore Contribution Agreement 1.0
>>Signed-off-by: Liming Gao <[email protected]>
>>---
>> BaseTools/Source/Python/build/build.py | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>>diff --git a/BaseTools/Source/Python/build/build.py
>>b/BaseTools/Source/Python/build/build.py
>>index 30ff5bb..67bd3b3 100644
>>--- a/BaseTools/Source/Python/build/build.py
>>+++ b/BaseTools/Source/Python/build/build.py
>>@@ -780,10 +780,14 @@ class Build():
>>
>> # print current build environment and configuration
>> EdkLogger.quiet("%-16s = %s" % ("WORKSPACE",
>>os.environ["WORKSPACE"]))
>>+ if "PACKAGES_PATH" in os.environ:
>>+ EdkLogger.quiet("%-16s = %s" % ("PACKAGES_PATH",
>>os.path.normcase(os.path.normpath(os.environ["PACKAGES_PATH"]))))>>
>>EdkLogger.quiet("%-16s = %s" % ("ECP_SOURCE",
>>os.environ["ECP_SOURCE"]))
>> EdkLogger.quiet("%-16s = %s" % ("EDK_SOURCE",
>>os.environ["EDK_SOURCE"]))
>> EdkLogger.quiet("%-16s = %s" % ("EFI_SOURCE",
>>os.environ["EFI_SOURCE"]))
>> EdkLogger.quiet("%-16s = %s" % ("EDK_TOOLS_PATH",
>>os.environ["EDK_TOOLS_PATH"]))
>>+ if "EDK_TOOLS_BIN" in os.environ:
>>+ EdkLogger.quiet("%-16s = %s" % ("EDK_TOOLS_BIN",
>>os.path.normcase(os.path.normpath(os.environ["EDK_TOOLS_BIN"]))))
>>
>> EdkLogger.info("")
>>
>>--
>>1.9.5.msysgit.0
>>
>>_______________________________________________
>>edk2-devel mailing list
>>[email protected]
>>https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
