Hi Jiewen,
Thanks for your review. I'll send a v2 version.
Heyi
On 11/09/2015 07:06 PM, Yao, Jiewen wrote:
Hi
Thanks for the update.
Would you consider adding Table Revision 0x2 as well?
Reviewed-by: [email protected]
Thank you
Yao Jiewen
-----Original Message-----
From: edk2-devel [mailto:[email protected]] On Behalf Of Heyi Guo
Sent: Monday, November 09, 2015 5:30 PM
To: [email protected]
Cc: Kinney, Michael D; Heyi Guo; Gao, Liming
Subject: [edk2] [PATCH] MdePkg/ACPI: Update SPCR table definition
Update SPCR table definition per SPCR specification v1.03.
Document link:
http://msdn.microsoft.com/en-us/library/windows/hardware/dn639132(v=vs.85).aspx
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Heyi Guo <[email protected]>
Cc: Michael D Kinney <[email protected]>
Cc: Liming Gao <[email protected]>
---
.../Include/IndustryStandard/SerialPortConsoleRedirectionTable.h | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
index 74ea5b3..958539c 100644
--- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
+++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
+++ h
@@ -44,7 +44,7 @@ typedef struct {
UINT8 StopBits;
UINT8 FlowControl;
UINT8 TerminalType;
- UINT8 Language;
+ UINT8 Reserved2;
UINT16 PciDeviceId;
UINT16 PciVendorId;
UINT8 PciBusNumber;
@@ -52,7 +52,7 @@ typedef struct {
UINT8 PciFunctionNumber;
UINT32 PciFlags;
UINT8 PciSegment;
- UINT32 Reserved2;
+ UINT32 Reserved3;
} EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
#pragma pack()
@@ -90,6 +90,10 @@ typedef struct {
/// I/O SAPIC interrupt (Global System Interrupt) ///
#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERRUPT_TYPE_SAPIC
0x4
+///
+/// ARMH GIC interrupt (Global System Interrupt) ///
+#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERRUPT_TYPE_GIC
0x8
//
// Baud Rate
--
2.6.2
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
