Shall you change the commit title to something like "error handling enhancement"?
Other looks good to me Reviewed-by: Feng Tian <[email protected]> Thanks Feng -----Original Message----- From: Ni, Ruiyu Sent: Thursday, November 12, 2015 14:11 To: [email protected] Cc: Ni, Ruiyu; Tian, Feng Subject: [Patch] MdeModulePkg/BmpImageDecoderLib: Support ImageFormatUnknown type Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni <[email protected]> Cc: Feng Tian <[email protected]> --- MdeModulePkg/Library/BmpImageDecoderLib/BmpImageDecoderLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Library/BmpImageDecoderLib/BmpImageDecoderLib.c b/MdeModulePkg/Library/BmpImageDecoderLib/BmpImageDecoderLib.c index 86dcc91..28afd4f 100644 --- a/MdeModulePkg/Library/BmpImageDecoderLib/BmpImageDecoderLib.c +++ b/MdeModulePkg/Library/BmpImageDecoderLib/BmpImageDecoderLib.c @@ -65,7 +65,7 @@ BmpImageDecoderLibConvertBmpToGopBlt ( ASSERT ((GopBlt != NULL) && (GopBltSize != NULL)); - if (ImageFormat != ImageFormatBmp) { + if ((ImageFormat != ImageFormatBmp) && (ImageFormat != ImageFormatUnknown)) { return EFI_UNSUPPORTED; } -- 1.9.5.msysgit.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
