Reviewed-by: Liming Gao <liming....@intel.com>
-----Original Message-----
From: Zeng, Star
Sent: Tuesday, November 17, 2015 5:47 PM
To: edk2-devel@lists.01.org
Cc: Gao, Liming
Subject: [PATCH] MdeModulePkg PeiCore: PeiInstallPeiMemory improper ASSERT test
on second call
The ASSERT (PrivateData->PeiMemoryInstalled) in if
(PrivateData->PeiMemoryInstalled) condition is useless, it should be ASSERT
(FALSE) to follow the code's expectation.
Cc: Liming Gao <liming....@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.z...@intel.com>
---
MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
index 36bdc73..2f9b9de 100644
--- a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
+++ b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c
@@ -96,7 +96,7 @@ PeiInstallPeiMemory (
//
if (PrivateData->PeiMemoryInstalled) {
DEBUG ((EFI_D_ERROR, "ERROR: PeiInstallPeiMemory is called more than
once!\n"));
- ASSERT (PrivateData->PeiMemoryInstalled);
+ ASSERT (FALSE);
return EFI_SUCCESS;
}
--
1.9.5.msysgit.0
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
