On 17 November 2015 at 12:39, Mark Rutland <[email protected]> wrote: > We force alignment to 2K after generating the DebugAgentVectorTable > symbol, and hence DebugAgentVectorTable itself may not be 2K-aligned, > and table entries may not be at the correct offset from the > DebugAgentVectorTable base address. > > Fix this by forcing alignment before generating the > DebugAgentVectorTable symbol. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Mark Rutland <[email protected]> > Cc: Leif Lindholm <[email protected]>
This is not causing any actual problems, since the minimum alignment is propagated to the entire .text section of the object file, and there is nothing that takes up space between the two symbols. But that does not make it correct, so Reviewed-by: Ard Biesheuvel <[email protected]> > --- > ArmPkg/Library/DebugAgentSymbolsBaseLib/AArch64/DebugAgentException.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/ArmPkg/Library/DebugAgentSymbolsBaseLib/AArch64/DebugAgentException.S > b/ArmPkg/Library/DebugAgentSymbolsBaseLib/AArch64/DebugAgentException.S > index 022e279..3fc090b 100644 > --- a/ArmPkg/Library/DebugAgentSymbolsBaseLib/AArch64/DebugAgentException.S > +++ b/ArmPkg/Library/DebugAgentSymbolsBaseLib/AArch64/DebugAgentException.S > @@ -16,12 +16,12 @@ GCC_ASM_EXPORT(DebugAgentVectorTable) > GCC_ASM_IMPORT(DefaultExceptionHandler) > > .text > +.align 11 > ASM_PFX(DebugAgentVectorTable): > > // > // Current EL with SP0 : 0x0 - 0x180 > // > -.align 11 > ASM_PFX(SynchronousExceptionSP0): > b ASM_PFX(SynchronousExceptionSP0) > > -- > 1.9.1 > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
