On 11/23/15 22:01, Kinney, Michael D wrote: > Laszlo, > > Based on size analysis of compiler output, (3) is not the smallest size. > That is why we prefer pre-init global.
Ugh, I completely forgot about physical flash, where size is a premium... > > Using your current patch style (1) in OvmfPkg specific modules is ok until > you can find a solution to your ctags issue. Thank you. Laszlo > > Mike > >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Laszlo Ersek >> Sent: Monday, November 23, 2015 12:34 PM >> To: Kinney, Michael D <michael.d.kin...@intel.com>; edk2-de...@ml01.01.org >> Cc: Justen, Jordan L <jordan.l.jus...@intel.com> >> Subject: Re: [edk2] [PATCH v4 07/41] OvmfPkg: add PEIM for providing >> TSEG-as-SMRAM during PEI >> >> On 11/23/15 21:13, Kinney, Michael D wrote: >>> Laszlo, >>> >>> Comments below. >>> >>> Mike >>> >>>> -----Original Message----- >>>> From: Laszlo Ersek [mailto:ler...@redhat.com] >>>> Sent: Monday, November 23, 2015 4:34 AM >>>> To: Kinney, Michael D <michael.d.kin...@intel.com>; >>>> edk2-de...@ml01.01.org >>>> Cc: Justen, Jordan L <jordan.l.jus...@intel.com> >>>> Subject: Re: [PATCH v4 07/41] OvmfPkg: add PEIM for providing >>>> TSEG-as-SMRAM during PEI >>>> >>>> On 11/21/15 07:36, Kinney, Michael D wrote: >>>>> Laszlo, >>>>> >>>>> Minor comments included below. I know from later items in this >>>>> thread that SMM_COMMUNICATE has already been removed in >>>> your local branch. >>>>> >>>>> Reviewed-by: Michael Kinney <michael.d.kin...@intel.com> >>>> >>>> Thank you. I've picked this up now. >>>> >>>> As far as I can see your comments, they are very similar to those you >>>> made for patch #8 (sorry, I read your feedback to patch #8 first); my >>>> followup is identical: >>>> - I've now listed the header file in [Sources], >>>> - I've fixed up the PRODUCES comment for the PPI GUID, >>>> - I'd like to stick with STATIC under OvmfPkg, >>> >>> Ok. >>> >>>> - I can move the definition of the global variable to the top, remove >>>> its initializer, and assign the members in the driver entry point >>>> instead, if you'd like me to. >>> >>> You don't have to assign members in driver entry point. You can still do >>> it in global variable. You just need function prototype before >> reference in global. >> >> I know I don't have to, technically; I just prefer the memberwise assignment >> in the driver entry point over the function prototypes. >> >> I proposed the memberwise assignment in the driver entry point as a >> compromise between your remark (= global variable defined in >> a stylistically wrong place) and between my preference (= function >> prototypes interfere with Jump To Tag functionality in editors). >> >> I can see these options: >> >> (1) What the code shows now. >> (2) Function prototypes ("forward declarations"), plus the global >> variable (with an initializer using those prototypes) moved near >> the top. >> (3) No forward declaration. Global variable moved to the top, but >> without an initializer. Memberwise assignment in entry point (which >> is usually at the bottom of the file). >> >> If you find (1) inferior style, but are equally fine with (2) and (3), then >> I'd like to pick (3). >> >> [snip] >> >> Thanks! >> Laszlo >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
