Sure. That would be better for me. Thanks a lot! I found Mike already replied to me to clarify API. It would not be long. I hope. :-)
Thank you Yao Jiewen -----Original Message----- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, November 25, 2015 8:00 PM To: Yao, Jiewen; edk2-de...@ml01.01.org Cc: Kinney, Michael D; Fan, Jeff Subject: Re: [edk2] [patch 2/3] UefiCpuPkg/PiSmmCpu: Add NULL func for 2 new APIs in SmmCpuFeaturesLib. On 11/25/15 12:50, Yao, Jiewen wrote: > Sorry, I should call you Laszlo. No problem. I still need to post v5 first, and then one or two remaining patches will need to receive reviews. I can commit the series after that, and then this series could be extended later. However, if you wouldn't want to wait that long with your series (which I find a reasonable desire), then please poke people to review your series quickly, and then commit it. If I can post my v5 such that it is rebased even on *your* series (not just the CpuS3DataDxe driver from Mike), that would be best. Thanks! Laszlo > > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yao, Jiewen > Sent: Wednesday, November 25, 2015 7:49 PM > To: Laszlo Ersek; edk2-de...@ml01.01.org > Cc: Kinney, Michael D; Fan, Jeff > Subject: Re: [edk2] [patch 2/3] UefiCpuPkg/PiSmmCpu: Add NULL func for 2 new > APIs in SmmCpuFeaturesLib. > > HI Ersek > May I know when you plan to check in your SmmCpuFeaturesLib for SMM? > > > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Wednesday, November 25, 2015 7:39 PM > To: Yao, Jiewen; edk2-de...@ml01.01.org > Cc: Kinney, Michael D; Fan, Jeff > Subject: Re: [edk2] [patch 2/3] UefiCpuPkg/PiSmmCpu: Add NULL func for 2 new > APIs in SmmCpuFeaturesLib. > > On 11/25/15 02:04, jiewen yao wrote: >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: "Yao, Jiewen" <jiewen....@intel.com> >> Cc: "Fan, Jeff" <jeff....@intel.com> >> Cc: "Kinney, Michael D" <michael.d.kin...@intel.com> >> --- >> .../Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 39 >> ++++++++++++++++++++++ >> 1 file changed, 39 insertions(+) >> >> diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c >> b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c >> index b839d31..d193f6c 100644 >> --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c >> +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c >> @@ -615,3 +615,42 @@ SmmCpuFeaturesWriteSaveStateRegister ( { >> return EFI_UNSUPPORTED; >> } >> + >> +/** >> + This function is hook point called after the >> +gEfiSmmReadyToLockProtocolGuid >> + notification is completely processed. >> +**/ >> +VOID >> +EFIAPI >> +SmmCpuFeaturesCompleteSmmReadyToLock ( >> + VOID >> + ) >> +{ >> +} >> + >> +/** >> + This API provides a method for a CPU to allocate a specific region for >> storing page tables. >> + >> + Allocates the number of 4KB pages of type EfiRuntimeServicesData >> + and returns a pointer to the allocated buffer. The buffer >> + returned is aligned on a 4KB boundary. If Pages is 0, then NULL >> + is returned. If there is not enough memory remaining to satisfy the >> request, then NULL is returned. >> + >> + This function can also return NULL if there is no preference on where the >> page tables are allocated in SMRAM. >> + >> + @param Pages The number of 4 KB pages to allocate. >> + >> + @return A pointer to the allocated buffer for page tables. >> + @retval NULL Fail to allocate a specific region for storing page >> tables, >> + Or there is no preference on where the page tables are >> allocated in SMRAM. >> + >> +**/ >> +VOID * >> +EFIAPI >> +SmmCpuFeaturesAllocatePageTableMemory ( >> + IN UINTN Pages >> + ) >> +{ >> + return NULL; >> +} >> + >> > > If this patch gets in before my OVMF SMM work, then I'll have to update the > SMM series (because it creates a separate SmmCpuFeaturesLib instance). > > If, on the other hand, the OVMF SMM series gets in first (which is somewhat > unlikely), then this series should be extended to add the null impl of the > new functions to OVMF's library instance as well. > > Thanks! > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
