On 25 November 2015 at 14:09, Cohen, Eugene <eug...@hp.com> wrote: > Ard, > > Thanks - I'm still working on trying to get you and Leif included. Wouldn't > it be a nice feature if the mail server detected 'ArmPkg' and then > automatically put you two on the To: line? > >> Also, you need to add your Signed-off-by and Contributed-under lines, or we >> will not be able to merge this. > > I did add the signoff/contribution but I now see I put it in the wrong place, > after the patch instead of after the commit message - I'll work on that. One > of these days I might actually get all the parts of a patch submission > correct. >
OK, I hadn't spotted that. The patch itself looks fine. Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> I trimmed the subject line, word wrapped the commit log, moved your Contributed-under and Signed-off-by lines into it, and committed it as SVN r18953 Thanks, Ard. > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, November 24, 2015 11:35 PM > To: Cohen, Eugene <eug...@hp.com> > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] ArmPkg: add missing > MigratePeiServicesTablePointer function required by update to the > PeiServicesTablePointerLib in svn 15115 > > On 24 November 2015 at 18:09, Cohen, Eugene <eug...@hp.com> wrote: >> As of SVN 15115 the PEI core needs a MigratePeiServicesTablePointer function. >> >> Background: The ArmPkg variant of the PeiServicesTablePointerLib implements >> the standard PEI Services table retrieval mechanism as defined in the PI >> Specification Volume 1 section 5.4.4 using the PIDRURW registers. No >> special action is required on ARM to migrate the PEI Services table pointer >> after main memory initialization but a function must be implemented >> nonetheless. >> > > Thanks Eugene. > > Please cc me and Leif when you send patches to the list that you > expect us to look at. > Also, you need to add your Signed-off-by and Contributed-under lines, > or we will not be able to merge this. > > Thanks, > Ard. > > >> --- >> .../PeiServicesTablePointer.c | 23 >> ++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> >> diff --git >> a/ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointer.c >> b/ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointer.c >> index c2a4a35..9320637 100644 >> --- a/ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointer.c >> +++ b/ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointer.c >> @@ -60,3 +60,26 @@ GetPeiServicesTablePointer ( >> { >> return (CONST EFI_PEI_SERVICES **)ArmReadTpidrurw(); >> } >> + >> +/** >> +Perform CPU specific actions required to migrate the PEI Services Table >> +pointer from temporary RAM to permanent RAM. >> + >> +For IA32 CPUs, the PEI Services Table pointer is stored in the 4 bytes >> +immediately preceding the Interrupt Descriptor Table (IDT) in memory. >> +For X64 CPUs, the PEI Services Table pointer is stored in the 8 bytes >> +immediately preceding the Interrupt Descriptor Table (IDT) in memory. >> +For Itanium and ARM CPUs, a the PEI Services Table Pointer is stored in >> +a dedicated CPU register. This means that there is no memory storage >> +associated with storing the PEI Services Table pointer, so no additional >> +migration actions are required for Itanium or ARM CPUs. >> + >> +**/ >> +VOID >> +EFIAPI >> +MigratePeiServicesTablePointer( >> +VOID >> +) >> +{ >> + return; >> +} >> -- >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Eugene Cohen <eug...@hp.com> >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
