On 11/27/15 15:07, Yao, Jiewen wrote: > So quick! > Thank you very much to catch this!
You'll get used to Paolo... the only reason he opens the SDM is not because he needs to look up the details. He remembers those. He looks at the SDM in order to find the containing chapter & section numbers for the details he already knows, so that others can look up the reference too. ... That's my impression anyway! ;) Laszlo > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Paolo > Bonzini > Sent: Friday, November 27, 2015 9:53 PM > To: Yao, Jiewen; edk2-de...@ml01.01.org > Cc: Kinney, Michael D; Fan, Jeff > Subject: Re: [edk2] [patch 1/2] UefiCpuPkg/PiSmmCpu: Always set RW+P bit for > page table by default. > > > > On 25/11/2015 13:34, jiewen yao wrote: >> @@ -785,7 +785,7 @@ Gen4GPageTable ( >> // Set Page Directory Pointers >> // >> for (Index = 0; Index < 4; Index++) { >> - Pte[Index] = (UINTN)PageTable + EFI_PAGE_SIZE * (Index + 1) + IA32_PG_P; >> + Pte[Index] = (UINTN)PageTable + EFI_PAGE_SIZE * (Index + 1) + >> + PAGE_ATTRIBUTE_BITS; >> } >> Pte += EFI_PAGE_SIZE / sizeof (*Pte); >> > > For PAE you must not set bit 1 here. See the fix I've posted, it can be > included directly in this patch when you repost (so you still have two > patches, "Always set RW+P bit" and "Always set WP"). > > Thanks, > > Paolo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
