On 2015/11/3 15:34, Zhang, Chao B wrote:
Enable Secure Boot feature defined in UEFI2.5 ECR1263. Add VarCheck for 
AuditMode/DeployedMode

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang <[email protected]>
---
  .../VarCheckUefiLib/VarCheckUefiLibNullClass.c     | 22 ++++++++++++++++++++++
  1 file changed, 22 insertions(+)

The code change is good to me.
And please follow Laszlo's suggestion in [PATCH 0/5] to update the patch title. Another, please put this patch to be after [PATCH 2/5] since [PATCH 2/5] is to add the definitions, and this patch and other following patches are to consume the definitions.

If you follow the suggestions above, you can have my
Reviewed-by: Star Zeng <[email protected]>

Thanks,
Star


diff --git a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c 
b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c
index 15144bd..a4268ae 100644
--- a/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c
+++ b/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLibNullClass.c
@@ -426,6 +426,28 @@ UEFI_DEFINED_VARIABLE_ENTRY mGlobalVariableList[] = {
      NULL
    },
    {
+    EFI_AUDIT_MODE_NAME,
+    {
+      VAR_CHECK_VARIABLE_PROPERTY_REVISION,
+      0,
+      VARIABLE_ATTRIBUTE_BS_RT,
+      sizeof (UINT8),
+      sizeof (UINT8)
+    },
+    NULL
+  },
+  {
+    EFI_DEPLOYED_MODE_NAME,
+    {
+      VAR_CHECK_VARIABLE_PROPERTY_REVISION,
+      0,
+      VARIABLE_ATTRIBUTE_BS_RT,
+      sizeof (UINT8),
+      sizeof (UINT8)
+    },
+    NULL
+  },
+  {
      EFI_KEY_EXCHANGE_KEY_NAME,
      {
        VAR_CHECK_VARIABLE_PROPERTY_REVISION,


_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to