Meenakshi,

Are you using any EL3 firmware with GICv3 support in it?
Is "PcdArmGicV3WithV2Legacy" being used?
Is the ARM Architectural Timer working for you? (If this works, keyboard input 
work fine.)

I think this is the same problem I ran into before, where the interrupt for the 
arm architecture timer was not triggering.

The Affinity needs to be set properly for GICv3 support to work properly.

GICD_CTLR.ARE_S bit. This enables affinity routing for the secure and the 
normal worlds. When secure world(EL3) is operating in the legacy mode, UEFI is 
responsible for enabling affinity routing for the normal world. There is a bug 
in the UEFI code that programs the GICD_CTLR.ARE_NS bit. The GICv3 
specification clearly says that changing the ARE_NS from 1 to 0 is 
UNPREDICATABLE. The patch is attached.

Will be sending this patch out for Review to this list soon. Please let me know 
whether this resolves this for you.

diff --git a/ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c 
b/ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c
index 3157243..f90391b 100644
--- a/ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c
+++ b/ArmPkg/Drivers/ArmGic/ArmGicNonSecLib.c
@@ -33,9 +33,9 @@ ArmGicEnableDistributor (
     MmioWrite32 (GicDistributorBase + ARM_GIC_ICDDCR, 0x1);
   } else {
     if (MmioRead32 (GicDistributorBase + ARM_GIC_ICDDCR) & ARM_GIC_ICDDCR_ARE) 
{
-      MmioWrite32 (GicDistributorBase + ARM_GIC_ICDDCR, 0x2);
+      MmioOr32 (GicDistributorBase + ARM_GIC_ICDDCR, 0x2);
     } else {
-      MmioWrite32 (GicDistributorBase + ARM_GIC_ICDDCR, 0x1);
+      MmioOr32 (GicDistributorBase + ARM_GIC_ICDDCR, 0x1);
     }
   }
 }

Thanks,
Supreeth
-----Original Message-----
From: edk2-devel [mailto:[email protected]] On Behalf Of 
Meenakshi Aggarwal
Sent: Sunday, November 29, 2015 9:53 PM
To: [email protected]
Subject: [edk2] GICv3 support

Hi,


I have added support of GICv3 in my board package by defining

  gArmTokenSpaceGuid.PcdGicDistributorBase|0x6000000
  gArmTokenSpaceGuid.PcdGicRedistributorsBase|0x6100000


But still I am unable to take input from keyboard.

Do I need to do some more settings for this.

Kindly reply.



Thanks & Regards,
Meenakshi
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.

_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to