Ard, My workflow is a Windows host using TortoiseGit and I'm formatting a patch and using send-mail using MAPI which invoked Outlook. I'm guessing this couldn't be more different than your workflow. :)
I don't think another mail client works well with our IT department but I'll see what I can do for the line wrapping. Thanks, Eugene > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, December 01, 2015 11:42 AM > To: Cohen, Eugene <eug...@hp.com> > Cc: leif.lindh...@linaro.org; edk2-devel@lists.01.org > Subject: Re: [PATCH] ArmPkg: Convert whole-cache > InvalidateInstructionCache to just ASSERT > > On 1 December 2015 at 19:26, Ard Biesheuvel > <ard.biesheu...@linaro.org> wrote: > > On 1 December 2015 at 19:09, Cohen, Eugene <eug...@hp.com> > wrote: > >> In SVN 18756 ("disallow whole D-cache maintenance operations") > InvalidateInstructionCache was modified to remove the full data cache > clean but left the full instruction cache invalidate. The change was made > to address issues in the set/way clean methodology but the resulting > code could lead someone to a painful debug. If a component called this > function, the proper code would not be flushed to the PoU, since the > intent of this function is not only to invalidate the I-cache but to provide > coherency after code loading / modification. This change simply places > an ASSERT(FALSE) in this function to avoid this hazard. > >> > > > > Next time, could you please line wrap the commit log to 72 characters? > > > >> Contributed-under: TianoCore Contribution Agreement 1.0 > >> Signed-off-by: Eugene Cohen <eug...@hp.com> > > > > Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > > > > I committed this as SVN r19084 > > Unfortunately, I had to recreate the patch, since I could not apply it > from the email, as it was using quoted printable transfer encoding. > > May I suggest that you look into using 'git send-email' or perhaps > another mail client for contributing patches? That should also help > with the line wrapping issue. > > Thanks. > Ard. > > > > >> --- > >> > ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.c > | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git > a/ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib > .c > b/ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib > .c > >> index b95ddb4..85d38b7 100644 > >> --- > a/ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib > .c > >> +++ > b/ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib > .c > >> @@ -45,7 +45,7 @@ InvalidateInstructionCache ( > >> VOID > >> ) > >> { > >> - ArmInvalidateInstructionCache(); > >> + ASSERT(FALSE); > >> } > >> > >> VOID > >> -- > >> 1.9.5.msysgit.0 > >> _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
