On 2015/12/3 2:58, Cohen, Eugene wrote:
Star,
Do you have the patch tested on your real platforms (with and without
InstallPeiMemory()?
Yes, we've been running this way for a couple years. I had it on my list of
changes to upstream and forgot about it until now. The only other requirement
for this to work correctly is for the memory intiialization driver to not call
InstallPeiMemory on S3 resume.
Thanks for the information.
Current code will install Decompress and Extraction PPI for both normal and
S3 path in entry point, but Decompress and Extraction PPI need to use
AllocatePages() that only works after memory discovered as PI spec
describes.
Then should the code be also updated to install Decompress and Extraction
PPI in memory discovered ppi notify with
EFI_PEI_PPI_DESCRIPTOR_NOTIFY_DISPATCH?
This makes sense to me - don't publish a service that cannot be handled. So as
long as S3 resume doesn't require section extraction (which seems unlikely)
then DXE IPL can just expose the reduced set of PPIs. Do you want to propose
something or shall I?
S3 still need the PPIs in case platform have InstallPeiMemory() call and
compressed PEIM even at S3 path. So the code can't to do not install the
PPIs at S3 path.
Please go to propose the code change.
Thanks,
Star
Thanks,
Eugene
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
