I just realized I was using old build tools. Build failure disappears using trunk tools.
Sorry for the false alarm:) Regards, Ray -----Original Message----- From: Justen, Jordan L Sent: Thursday, December 10, 2015 4:51 PM To: Ni, Ruiyu <ruiyu...@intel.com>; Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin <shumin....@intel.com> Subject: RE: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8 On 2015-12-10 00:33:32, Ni, Ruiyu wrote: > build -p ShellPkg/ShellPkg.dsc -a IA32 -t VS2013x86 > > The source code should have "#include <Protocol/Bds.h>" and other > include statements, otherwise CL cannot recognize the protocol GUID > ID. > I think the change to ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf causes: extern EFI_GUID gEfiBdsArchProtocolGuid; to be added in: Build/Shell/DEBUG_GCC49/X64/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib/DEBUG/AutoGen.h Which is why the include is not needed for using the GUID. > Can you make sure that you don't have local uncommitted changes? > The tree was clean both on Linux and Windows. -Jordan > > -----Original Message----- > From: Justen, Jordan L > Sent: Thursday, December 10, 2015 4:25 PM > To: Ni, Ruiyu <ruiyu...@intel.com>; Carsey, Jaben <jaben.car...@intel.com>; > edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin <shumin....@intel.com> > Subject: RE: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8 > > On 2015-12-09 22:47:42, Ni, Ruiyu wrote: > > more than 100 build errors: > > > > gEfiBdsArchProtocolGuid: undeclared identifier > > ... > > I also tried r19178 on VS2010, X64, with > > build -p ShellPkg\ShellPkg.dsc > > I still didn't see a build error. What toolchain and build command are > you using? > > Jaben, Shumin, can you reproduce the build error? > > -Jordan > > > > > -----Original Message----- > > From: Justen, Jordan L > > Sent: Thursday, December 10, 2015 2:17 PM > > To: Ni, Ruiyu <ruiyu...@intel.com>; Carsey, Jaben <jaben.car...@intel.com>; > > edk2-devel@lists.01.org > > Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin > > <shumin....@intel.com> > > Subject: RE: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to > > utf-8 > > > > On 2015-12-09 20:20:31, Ni, Ruiyu wrote: > > > r19177 check in breaks the build. Seems like the "#include" is > > > missing for many newly supported protocols. > > > I verified the checked r19180 after rolling back the r19177. > > > > I can't get a build error with GCC. I've tried r19178-19181. What is > > the build error? > > > > -Jordan > > > > > > > > -----Original Message----- > > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > > > Jordan Justen > > > Sent: Thursday, December 10, 2015 7:12 AM > > > To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org > > > Cc: Carsey, Jaben <jaben.car...@intel.com>; Qiu, Shumin > > > <shumin....@intel.com> > > > Subject: Re: [edk2] [PATCH v2 17/20] ShellPkg: Convert all .uni files to > > > utf-8 > > > > > > As requested by Jaben, I committed these two ShellPkg patches before > > > the rest of the series: > > > > > > r19176 | ShellPkg: Convert all .uni files to utf-8 > > > r19177 | ShellPkg: Make 'dh' support showing all spec defined protocols. > > > > > > On 2015-12-04 14:14:46, Carsey, Jaben wrote: > > > > Agreed. that works fine too... > > > > > > > > > -----Original Message----- > > > > > From: Justen, Jordan L > > > > > Sent: Friday, December 04, 2015 2:14 PM > > > > > To: Carsey, Jaben <jaben.car...@intel.com>; edk2-devel@lists.01.org > > > > > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > > > > > <jaben.car...@intel.com> > > > > > Subject: RE: [PATCH v2 17/20] ShellPkg: Convert all .uni files to > > > > > utf-8 > > > > > Importance: High > > > > > > > > > > On 2015-12-04 13:16:34, Carsey, Jaben wrote: > > > > > > There is a large change outstanding that was reviewed, but not yet > > > > > > committed for updating DH to display additional protocols. Can you > > > > > > commit that before this change? > > > > > > > > > > How about we do the opposite? Commit this one first, and then rebase > > > > > that patch. This would let us actually see the diff of that change in > > > > > source control. > > > > > > > > > > I'd be willing to do the rebase for that patch. > > > > > > > > > > -Jordan > > > > > > > > > > > > > > > > > If yes, > > > > > > > > > > > > Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Justen, Jordan L > > > > > > > Sent: Friday, December 04, 2015 12:14 PM > > > > > > > To: edk2-devel@lists.01.org > > > > > > > Cc: Justen, Jordan L <jordan.l.jus...@intel.com>; Carsey, Jaben > > > > > > > <jaben.car...@intel.com>; Qiu, Shumin <shumin....@intel.com> > > > > > > > Subject: [PATCH v2 17/20] ShellPkg: Convert all .uni files to > > > > > > > utf-8 > > > > > > > Importance: High > > > > > > > > > > > > > > To convert these files I ran: > > > > > > > > > > > > > > $ python3 BaseTools/Scripts/ConvertUni.py ShellPkg > > > > > > > > > > > > > > Cc: Jaben Carsey <jaben.car...@intel.com> > > > > > > > Cc: Shumin Qiu <shumin....@intel.com> > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > > > > > > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > > > > > > > --- > > > > > > > ShellPkg/Application/Shell/Shell.uni | Bin 4840 -> > > > > > > > 2419 bytes > > > > > > > ShellPkg/Library/UefiDpLib/UefiDpLib.uni | Bin 18146 > > > > > > > -> 9072 bytes > > > > > > > .../UefiHandleParsingLib/UefiHandleParsingLib.uni | Bin 32404 > > > > > > > -> 16201 > > > > > > > bytes > > > > > > > .../UefiShellBcfgCommandLib.uni | Bin 18414 > > > > > > > -> 9206 bytes > > > > > > > .../Edit/TextEditStrings.uni | Bin 11484 > > > > > > > -> 5741 bytes > > > > > > > .../HexEdit/HexeditStrings.uni | Bin 13156 > > > > > > > -> 6577 bytes > > > > > > > .../SmbiosView/SmbiosViewStrings.uni | Bin 109944 > > > > > > > -> 54971 > > > > > bytes > > > > > > > .../UefiShellDebug1CommandsLib.uni | Bin 140676 > > > > > > > -> 70337 > > > > > bytes > > > > > > > .../UefiShellDriver1CommandsLib.uni | Bin 70806 > > > > > > > -> 35402 bytes > > > > > > > .../UefiShellLevel1CommandsLib.uni | Bin 43930 > > > > > > > -> 21964 bytes > > > > > > > .../UefiShellLevel2CommandsLib.uni | Bin 109742 > > > > > > > -> 54870 > > > > > bytes > > > > > > > .../UefiShellLevel3CommandsLib.uni | Bin 44956 > > > > > > > -> 22477 bytes > > > > > > > .../UefiShellNetwork1CommandsLib.uni | Bin 21094 > > > > > > > -> 10546 > > > > > bytes > > > > > > > .../UefiShellTftpCommandLib.uni | Bin 9952 -> > > > > > > > 4975 bytes > > > > > > > 14 files changed, 0 insertions(+), 0 deletions(-) > > > > > > > > > > > > > > diff --git a/ShellPkg/Application/Shell/Shell.uni > > > > > > > b/ShellPkg/Application/Shell/Shell.uni > > > > > > > index 25cf699..301d879 100644 > > > > > > > Binary files a/ShellPkg/Application/Shell/Shell.uni and > > > > > > > b/ShellPkg/Application/Shell/Shell.uni differ > > > > > > > diff --git a/ShellPkg/Library/UefiDpLib/UefiDpLib.uni > > > > > > > b/ShellPkg/Library/UefiDpLib/UefiDpLib.uni > > > > > > > index 5bcb496..b092274 100644 > > > > > > > Binary files a/ShellPkg/Library/UefiDpLib/UefiDpLib.uni and > > > > > > > b/ShellPkg/Library/UefiDpLib/UefiDpLib.uni differ > > > > > > > diff --git > > > > > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > > > > > > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > > > > > > index d8e45d0..1d142e9 100644 > > > > > > > Binary files > > > > > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > > > > > > and > > > > > > > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > > > > differ > > > > > > > diff --git > > > > > > > > > > > > a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.uni > > > > > > > > > > > > b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.uni > > > > > > > index d34f314..b680a48 100644 > > > > > > > Binary files > > > > > > > > > > > > a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.uni > > > > > > > and > > > > > > > > > > > > b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.uni > > > > > > > differ > > > > > > > diff --git > > > > > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/TextEditStrings.uni > > > > > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/TextEditStrings.uni > > > > > > > index a61cae3..f799148 100644 > > > > > > > Binary files > > > > > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/TextEditStrings.uni > > > > > and > > > > > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/TextEditStrings.uni > > > > > > > differ > > > > > > > diff --git > > > > > > > > > > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/HexeditStrings.uni > > > > > > > > > > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/HexeditStrings.uni > > > > > > > index f521931..d9591ca 100644 > > > > > > > Binary files > > > > > > > > > > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/HexeditStrings.uni > > > > > > > and > > > > > > > > > > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/HexeditStrings.uni > > > > > > > differ > > > > > > > diff --git > > > > > > > > > > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewSt > > > > > > > rings.uni > > > > > > > > > > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewSt > > > > > > > rings.uni > > > > > > > index f368825..24fca87 100644 > > > > > > > Binary files > > > > > > > > > > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewSt > > > > > > > rings.uni and > > > > > > > > > > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewSt > > > > > > > rings.uni differ > > > > > > > diff --git > > > > > > > > > > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Command > > > > > > > sLib.uni > > > > > > > > > > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Command > > > > > > > sLib.uni > > > > > > > index e16175a..1974060 100644 > > > > > > > Binary files > > > > > > > > > > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Command > > > > > > > sLib.uni and > > > > > > > > > > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Command > > > > > > > sLib.uni differ > > > > > > > diff --git > > > > > > > > > > > > a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Commands > > > > > > > Lib.uni > > > > > > > > > > > > b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Command > > > > > > > sLib.uni > > > > > > > index a289853..a14469a 100644 > > > > > > > Binary files > > > > > > > > > > > > a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Commands > > > > > > > Lib.uni and > > > > > > > > > > > > b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Command > > > > > > > sLib.uni differ > > > > > > > diff --git > > > > > > > > > > > > a/ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1CommandsLi > > > > > > > b.uni > > > > > > > > > > > > b/ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1CommandsLi > > > > > > > b.uni > > > > > > > index 40fa57e..73e8655 100644 > > > > > > > Binary files > > > > > > > > > > > > a/ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1CommandsLi > > > > > > > b.uni and > > > > > > > > > > > > b/ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1CommandsLi > > > > > > > b.uni differ > > > > > > > diff --git > > > > > > > > > > > > a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLi > > > > > > > b.uni > > > > > > > > > > > > b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLi > > > > > > > b.uni > > > > > > > index cc2c33c..60f48f4 100644 > > > > > > > Binary files > > > > > > > > > > > > a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLi > > > > > > > b.uni and > > > > > > > > > > > > b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLi > > > > > > > b.uni differ > > > > > > > diff --git > > > > > > > > > > > > a/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLi > > > > > > > b.uni > > > > > > > > > > > > b/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLi > > > > > > > b.uni > > > > > > > index f4473ad..fc9c5d4 100644 > > > > > > > Binary files > > > > > > > > > > > > a/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLi > > > > > > > b.uni and > > > > > > > > > > > > b/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLi > > > > > > > b.uni differ > > > > > > > diff --git > > > > > > > > > > > > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Comm > > > > > > > andsLib.uni > > > > > > > > > > > > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Comm > > > > > > > andsLib.uni > > > > > > > index 4325959..4c68e41 100644 > > > > > > > Binary files > > > > > > > > > > > > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Comm > > > > > > > andsLib.uni and > > > > > > > > > > > > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Comm > > > > > > > andsLib.uni differ > > > > > > > diff --git > > > > > > > > > > > > a/ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.uni > > > > > > > > > > > > b/ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.uni > > > > > > > index d12a87c..33a8944 100644 > > > > > > > Binary files > > > > > > > > > > > > a/ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.uni > > > > > > > and > > > > > > > > > > > > b/ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.uni > > > > > > > differ > > > > > > > -- > > > > > > > 2.6.2 > > > > > > > > > _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel@lists.01.org > > > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
