Reviewed-by: Eric Dong <[email protected]> Checked in code at r19245.
Thanks, Eric -----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of Cecil Sheng Sent: Tuesday, December 15, 2015 10:37 AM To: [email protected] Cc: Cecil Sheng Subject: [edk2] [PATCH v2] MdeModulePkg: Improved SetupBrowser handling to failed GOTO callback. On a failed REF_OP callback, all changed fields in the Selection should be restored. Signed-off-by: Cecil Sheng <[email protected]> --- MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c index 356cd9c..de7e5aa 100644 --- a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c @@ -2,6 +2,7 @@ Utility functions for UI presentation. Copyright (c) 2004 - 2015, Intel Corporation. All rights reserved.<BR> +(C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -2505,10 +2506,14 @@ SetupBrowser ( // if (EFI_ERROR (Status)) { // - // Cross reference will not be taken + // Cross reference will not be taken, restore all essential + field // - Selection->FormId = Selection->Form->FormId; + Selection->Handle = mCurrentHiiHandle; + CopyMem (&Selection->FormSetGuid, &mCurrentFormSetGuid, sizeof (EFI_GUID)); + Selection->FormId = mCurrentFormId; Selection->QuestionId = 0; + Selection->Action = UI_ACTION_REFRESH_FORM; + } } -- 2.6.3.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
